From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f181.google.com (mail-ig0-f181.google.com [209.85.213.181]) by kanga.kvack.org (Postfix) with ESMTP id 343DD6B0254 for ; Tue, 15 Sep 2015 10:05:09 -0400 (EDT) Received: by igxx6 with SMTP id x6so13447155igx.1 for ; Tue, 15 Sep 2015 07:05:09 -0700 (PDT) Received: from smtprelay.hostedemail.com (smtprelay0211.hostedemail.com. [216.40.44.211]) by mx.google.com with ESMTP id kj5si6931429igb.0.2015.09.15.07.05.05 for ; Tue, 15 Sep 2015 07:05:05 -0700 (PDT) Date: Tue, 15 Sep 2015 10:04:54 -0400 From: Steven Rostedt Subject: Re: [PATCH V3 2/2] debugfs: don't assume sizeof(bool) to be 4 bytes Message-ID: <20150915100454.70dcc04d@gandalf.local.home> In-Reply-To: <27d37898b4be6b9b9f31b90135f8206ca079a868.1442305897.git.viresh.kumar@linaro.org> References: <9b705747a138c96c26faee5218f7b47403195b28.1442305897.git.viresh.kumar@linaro.org> <27d37898b4be6b9b9f31b90135f8206ca079a868.1442305897.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Viresh Kumar Cc: gregkh@linuxfoundation.org, linaro-kernel@lists.linaro.org, Rafael Wysocki , sboyd@codeaurora.org, arnd@arndb.de, Mark Brown , Akinobu Mita , Alexander Duyck , alsa-devel@alsa-project.org, Andrew Morton , Andy Lutomirski , Arik Nemtsov , "open list:QUALCOMM ATHEROS ATH10K WIRELESS DRIVER" , ath9k-devel@lists.ath9k.org, Avri Altman , "open list:B43 WIRELESS DRIVER" , Borislav Petkov , Brian Silverman , Catalin Marinas , Charles Keepax , Chaya Rachel Ivgi , Davidlohr Bueso , Dmitry Monakhov , Doug Thompson , Eliad Peller , Emmanuel Grumbach , Florian Fainelli , Gustavo Padovan , Haggai Eran , Hariprasad S , Ingo Molnar , Intel Linux Wireless , "open list:AMD IOMMU AMD-VI" , "James E.J. Bottomley" , Jaroslav Kysela , Jiri Slaby , Joe Perches , Joerg Roedel , Johan Hedberg , Johannes Berg , Johannes Weiner , Jonathan Corbet , Joonsoo Kim , Kalle Valo , Larry Finger , Len Brown , Liam Girdwood , "open list:ACPI" , "moderated list:ARM64 PORT AARCH64 ARCHITECTURE" , "open list:BLUETOOTH DRIVERS" , "open list:DOCUMENTATION" , "open list:EDAC-CORE" , open list , "open list:MEMORY MANAGEMENT" , "open list:CISCO SCSI HBA DRIVER" , "open list:ULTRA-WIDEBAND UWB SUBSYSTEM:" , "open list:NETWORKING DRIVERS WIRELESS" , Luciano Coelho , "Luis R. Rodriguez" , Marcel Holtmann , Mauro Carvalho Chehab , Mel Gorman , Michael Kerrisk , Michal Hocko , Narsimhulu Musini , "open list:CXGB4 ETHERNET DRIVER CXGB4" , Nick Kossifidis , "open list:WOLFSON MICROELECTRONICS DRIVERS" , Peter Zijlstra , QCA ath9k Development , Richard Fitzgerald , Sasha Levin , Sebastian Andrzej Siewior , Sebastian Ott , Sesidhar Baddela , Stanislaw Gruszka , Takashi Iwai , Tejun Heo , Thomas Gleixner , Tomas Winkler , Vlastimil Babka , Wang Long , Will Deacon , Linus Torvalds On Tue, 15 Sep 2015 14:04:59 +0530 Viresh Kumar wrote: > diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c > index 2614a839c60d..f11e17ad7834 100644 > --- a/drivers/acpi/ec.c > +++ b/drivers/acpi/ec.c > @@ -1237,7 +1237,7 @@ ec_parse_device(acpi_handle handle, u32 Level, void *context, void **retval) > /* Use the global lock for all EC transactions? */ > tmp = 0; > acpi_evaluate_integer(handle, "_GLK", NULL, &tmp); > - ec->global_lock = tmp; > + ec->global_lock = !!tmp; BTW, the above is equivalent if global_lock is of type bool. -- Steve > ec->handle = handle; > return AE_CTRL_TERMINATE; > } > diff --git a/drivers/acpi/internal.h b/drivers/acpi/internal.h > index 9db196de003c..5a72e2b140fc 100644 > --- a/drivers/acpi/internal.h > +++ b/drivers/acpi/internal.h > @@ -138,7 +138,7 @@ struct acpi_ec { > unsigned long gpe; > unsigned long command_addr; > unsigned long data_addr; > - u32 global_lock; > + bool global_lock; > unsigned long flags; > unsigned long reference_count; > struct mutex mutex; -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org