linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@kernel.org>
To: David Rientjes <rientjes@google.com>
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	gregkh@linuxfoundation.org, linux-mm@kvack.org
Subject: Re: [PATCH] android, lmk: Send SIGKILL before setting TIF_MEMDIE.
Date: Fri, 11 Sep 2015 15:51:51 +0200	[thread overview]
Message-ID: <20150911135151.GK3417@dhcp22.suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.10.1509091454020.20924@chino.kir.corp.google.com>

On Wed 09-09-15 14:55:59, David Rientjes wrote:
> On Sun, 6 Sep 2015, Tetsuo Handa wrote:
> 
> > It was observed that setting TIF_MEMDIE before sending SIGKILL at
> > oom_kill_process() allows memory reserves to be depleted by allocations
> > which are not needed for terminating the OOM victim.
> > 
> 
> I don't understand what you are trying to fix.  Sending a SIGKILL first 
> does not guarantee that it is handling that signal before accessing memory 
> reserves. 

Yes it doesn't guarantee that but it kicks the task from userspace so
that it cannot deplete the memory reserves from the _userspace_ under
its controll. It still can consume some amount of memory from the kernel
but that shouldn't be under control of the task.
-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2015-09-11 13:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-06  5:25 Tetsuo Handa
2015-09-09 21:55 ` David Rientjes
2015-09-11 13:51   ` Michal Hocko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150911135151.GK3417@dhcp22.suse.cz \
    --to=mhocko@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-mm@kvack.org \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox