From: Tejun Heo <tj@kernel.org>
To: Tang Chen <tangchen@cn.fujitsu.com>
Cc: jiang.liu@linux.intel.com, mika.j.penttila@gmail.com,
mingo@redhat.com, akpm@linux-foundation.org, rjw@rjwysocki.net,
hpa@zytor.com, yasu.isimatu@gmail.com,
isimatu.yasuaki@jp.fujitsu.com, kamezawa.hiroyu@jp.fujitsu.com,
izumi.taku@jp.fujitsu.com, gongzhaogang@inspur.com,
qiaonuohan@cn.fujitsu.com, x86@kernel.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Gu Zheng <guz.fnst@cn.fujitsu.com>
Subject: Re: [PATCH v2 3/7] x86, gfp: Cache best near node for memory allocation.
Date: Thu, 10 Sep 2015 15:29:35 -0400 [thread overview]
Message-ID: <20150910192935.GI8114@mtj.duckdns.org> (raw)
In-Reply-To: <1441859269-25831-4-git-send-email-tangchen@cn.fujitsu.com>
Hello,
On Thu, Sep 10, 2015 at 12:27:45PM +0800, Tang Chen wrote:
> diff --git a/include/linux/gfp.h b/include/linux/gfp.h
> index ad35f30..1a1324f 100644
> --- a/include/linux/gfp.h
> +++ b/include/linux/gfp.h
> @@ -307,13 +307,19 @@ static inline struct page *alloc_pages_node(int nid, gfp_t gfp_mask,
> if (nid < 0)
> nid = numa_node_id();
>
> + if (!node_online(nid))
> + nid = get_near_online_node(nid);
> +
> return __alloc_pages(gfp_mask, order, node_zonelist(nid, gfp_mask));
> }
Why not just update node_data[]->node_zonelist in the first place?
Also, what's the synchronization rule here? How are allocators
synchronized against node hot [un]plugs?
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-09-10 19:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 4:27 [PATCH v2 0/7] Make cpuid <-> nodeid mapping persistent Tang Chen
2015-09-10 4:27 ` [PATCH v2 1/7] x86, numa: Move definition of find_near_online_node() forward Tang Chen
2015-09-10 4:27 ` [PATCH v2 2/7] x86, numa: Introduce a node to node array to map a node to its best online node Tang Chen
2015-09-10 4:27 ` [PATCH v2 3/7] x86, gfp: Cache best near node for memory allocation Tang Chen
2015-09-10 19:29 ` Tejun Heo [this message]
2015-09-10 19:38 ` Tejun Heo
2015-09-10 22:02 ` Christoph Lameter
2015-09-10 22:08 ` Tejun Heo
2015-09-11 0:14 ` Christoph Lameter
2015-09-26 9:35 ` Tang Chen
2015-09-26 9:31 ` Tang Chen
2015-09-26 17:53 ` Tejun Heo
2015-09-28 1:50 ` Tang Chen
2015-09-10 4:27 ` [PATCH v2 4/7] x86, acpi, cpu-hotplug: Enable acpi to register all possible cpus at boot time Tang Chen
2015-09-10 23:10 ` Rafael J. Wysocki
2015-09-26 9:44 ` Tang Chen
2015-09-10 4:27 ` [PATCH v2 5/7] x86, acpi, cpu-hotplug: Introduce apicid_to_cpuid[] array to store persistent cpuid <-> apicid mapping Tang Chen
2015-09-10 19:55 ` Tejun Heo
2015-09-26 9:52 ` Tang Chen
2015-09-26 17:56 ` Tejun Heo
2015-09-28 1:57 ` Tang Chen
2015-09-10 4:27 ` [PATCH v2 6/7] x86, acpi, cpu-hotplug: Enable MADT APIs to return disabled apicid Tang Chen
2015-09-10 4:27 ` [PATCH v2 7/7] x86, acpi, cpu-hotplug: Set persistent cpuid <-> nodeid mapping when booting Tang Chen
2015-10-23 19:49 ` [PATCH v2 0/7] Make cpuid <-> nodeid mapping persistent Yasuaki Ishimatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150910192935.GI8114@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=gongzhaogang@inspur.com \
--cc=guz.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=izumi.taku@jp.fujitsu.com \
--cc=jiang.liu@linux.intel.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mika.j.penttila@gmail.com \
--cc=mingo@redhat.com \
--cc=qiaonuohan@cn.fujitsu.com \
--cc=rjw@rjwysocki.net \
--cc=tangchen@cn.fujitsu.com \
--cc=x86@kernel.org \
--cc=yasu.isimatu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox