From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Mel Gorman <mgorman@suse.de>,
David Rientjes <rientjes@google.com>
Subject: Re: [PATCH 3/3] mm, compaction: disginguish contended status in tracepoint
Date: Mon, 7 Sep 2015 14:53:06 +0900 [thread overview]
Message-ID: <20150907055306.GD21207@js1304-P5Q-DELUXE> (raw)
In-Reply-To: <1440689044-2922-3-git-send-email-vbabka@suse.cz>
On Thu, Aug 27, 2015 at 05:24:04PM +0200, Vlastimil Babka wrote:
> Compaction returns prematurely with COMPACT_PARTIAL when contended or has fatal
> signal pending. This is ok for the callers, but might be misleading in the
> traces, as the usual reason to return COMPACT_PARTIAL is that we think the
> allocation should succeed. This patch distinguishes the premature ending
> condition. Further distinguishing the exact reason seems unnecessary for now.
isolate_migratepages() could return ISOLATE_ABORT and skip to call
compact_finished(). trace_mm_compaction_end() will print
COMPACT_PARTIAL in this case and we cannot distinguish premature
ending condition. Is it okay?
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-09-07 5:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 15:24 [PATCH 1/3] mm, compaction: export tracepoints status strings to userspace Vlastimil Babka
2015-08-27 15:24 ` [PATCH 2/3] mm, compaction: export tracepoints zone names " Vlastimil Babka
2015-08-31 14:58 ` Steven Rostedt
2015-08-31 15:02 ` Vlastimil Babka
2015-08-31 15:13 ` Steven Rostedt
2015-08-31 15:32 ` Steven Rostedt
2015-08-27 15:24 ` [PATCH 3/3] mm, compaction: disginguish contended status in tracepoint Vlastimil Babka
2015-09-07 5:53 ` Joonsoo Kim [this message]
2015-09-08 16:29 ` Vlastimil Babka
2015-08-31 14:55 ` [PATCH 1/3] mm, compaction: export tracepoints status strings to userspace Steven Rostedt
2015-08-31 15:27 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150907055306.GD21207@js1304-P5Q-DELUXE \
--to=iamjoonsoo.kim@lge.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox