linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: arve@android.com, riandrews@android.com,
	devel@driverdev.osuosl.org, linux-mm@kvack.org,
	mhocko@kernel.org, rientjes@google.com, hannes@cmpxchg.org
Subject: Re: [PATCH 2/2] android, lmk: Reverse the order of setting TIF_MEMDIE and sending SIGKILL.
Date: Wed, 2 Sep 2015 18:06:20 -0700	[thread overview]
Message-ID: <20150903010620.GC31349@kroah.com> (raw)
In-Reply-To: <201508262119.IHA93770.JOOtFHMSFLOQVF@I-love.SAKURA.ne.jp>

On Wed, Aug 26, 2015 at 09:19:48PM +0900, Tetsuo Handa wrote:
> Hello.
> 
> Should selected_tasksize be added to rem even when TIF_MEMDIE was not set?
> 
> Please see a thread from http://www.spinics.net/lists/linux-mm/msg93246.html
> if you want to know why to reverse the order.
> ----------------------------------------
> >From 2d4cc11d8128e4c1397631b91fea78da3eaefb47 Mon Sep 17 00:00:00 2001
> From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Date: Wed, 26 Aug 2015 20:52:39 +0900
> Subject: [PATCH 2/2] android, lmk: Reverse the order of setting TIF_MEMDIE and sending SIGKILL.
> 
> If we set TIF_MEMDIE before sending SIGKILL, memory reserves could be
> spent for allocations which are not needed for terminating the victim.
> Reverse the order as with oom_kill_process() does.


I can't take a patch that I have to hand-edit in order to apply it :(

And if we aren't taking patch 1/2, I guess this one isn't needed either?

thanks,

greg k-h

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2015-09-03  1:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-26 12:17 [PATCH 1/2] android, lmk: Protect task->comm with task_lock Tetsuo Handa
2015-08-26 12:19 ` [PATCH 2/2] android, lmk: Reverse the order of setting TIF_MEMDIE and sending SIGKILL Tetsuo Handa
2015-08-26 15:34   ` Tetsuo Handa
2015-08-27  8:44     ` Michal Hocko
2015-09-03  1:06   ` Greg KH [this message]
2015-09-04 14:05     ` Michal Hocko
2015-09-04 17:15       ` Greg KH
2015-09-04 18:06         ` Tetsuo Handa
2015-09-04 20:29           ` Greg KH
2015-09-01 22:28 ` [PATCH 1/2] android, lmk: Protect task->comm with task_lock David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150903010620.GC31349@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arve@android.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=riandrews@android.com \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox