From: Michal Hocko <mhocko@kernel.org>
To: Yaowei Bai <bywxiaobai@163.com>
Cc: akpm@linux-foundation.org, mgorman@suse.de, vbabka@suse.cz,
js1304@gmail.com, hannes@cmpxchg.org,
alexander.h.duyck@redhat.com, sasha.levin@oracle.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm/page_alloc: change sysctl_lower_zone_reserve_ratio to sysctl_lowmem_reserve_ratio
Date: Tue, 25 Aug 2015 17:28:23 +0200 [thread overview]
Message-ID: <20150825152822.GJ6285@dhcp22.suse.cz> (raw)
In-Reply-To: <1440511291-3990-1-git-send-email-bywxiaobai@163.com>
On Tue 25-08-15 22:01:30, Yaowei Bai wrote:
> We use sysctl_lowmem_reserve_ratio rather than sysctl_lower_zone_reserve_ratio to
> determine how aggressive the kernel is in defending lowmem from the possibility of
> being captured into pinned user memory. To avoid misleading, correct it in some
> comments.
We never had a sysctl like that AFAICS in git history.
> Signed-off-by: Yaowei Bai <bywxiaobai@163.com>
Acked-by: Michal Hocko <mhocko@suse.com>
> ---
> mm/page_alloc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 0a0acdb..b730f7d 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -6043,7 +6043,7 @@ void __init page_alloc_init(void)
> }
>
> /*
> - * calculate_totalreserve_pages - called when sysctl_lower_zone_reserve_ratio
> + * calculate_totalreserve_pages - called when sysctl_lowmem_reserve_ratio
> * or min_free_kbytes changes.
> */
> static void calculate_totalreserve_pages(void)
> @@ -6087,7 +6087,7 @@ static void calculate_totalreserve_pages(void)
>
> /*
> * setup_per_zone_lowmem_reserve - called whenever
> - * sysctl_lower_zone_reserve_ratio changes. Ensures that each zone
> + * sysctl_lowmem_reserve_ratio changes. Ensures that each zone
> * has a correct pages reserved value, so an adequate number of
> * pages are left in the zone after a successful __alloc_pages().
> */
> --
> 1.9.1
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-08-25 15:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 14:01 Yaowei Bai
2015-08-25 14:01 ` [PATCH 2/2] Documentation: clarify in calculating zone protection Yaowei Bai
2015-08-25 15:06 ` Michal Hocko
2015-08-26 14:29 ` Yaowei Bai
2015-08-25 23:33 ` David Rientjes
2015-08-25 15:28 ` Michal Hocko [this message]
2015-08-25 23:33 ` [PATCH 1/2] mm/page_alloc: change sysctl_lower_zone_reserve_ratio to sysctl_lowmem_reserve_ratio David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150825152822.GJ6285@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@redhat.com \
--cc=bywxiaobai@163.com \
--cc=hannes@cmpxchg.org \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=sasha.levin@oracle.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox