linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@kernel.org>
To: David Rientjes <rientjes@google.com>
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	akpm@linux-foundation.org, mgorman@suse.de, hannes@cmpxchg.org,
	oleg@redhat.com, vbabka@suse.cz, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [patch -mm] mm, oom: add global access to memory reserves on livelock
Date: Tue, 25 Aug 2015 17:26:51 +0200	[thread overview]
Message-ID: <20150825152650.GI6285@dhcp22.suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.10.1508241404380.32561@chino.kir.corp.google.com>

On Mon 24-08-15 14:10:10, David Rientjes wrote:
> On Fri, 21 Aug 2015, Tetsuo Handa wrote:
> 
> > Why can't we think about choosing more OOM victims instead of granting access
> > to memory reserves?
> > 
> 
> We have no indication of which thread is holding a mutex that would need 
> to be killed, so we'd be randomly killing processes waiting for forward 
> progress.  A worst-case scenario would be the thread is OOM_DISABLE and we 
> kill every process on the system needlessly.  This problem obviously 
> occurs often enough that killing all userspace isnt going to be a viable 
> solution.
> 
> > Also, SysRq might not be usable under OOM because workqueues can get stuck.
> > The panic_on_oom_timeout was first proposed using a workqueue but was
> > updated to use a timer because there is no guarantee that workqueues work
> > as expected under OOM.
> > 
> 
> I don't know anything about a panic_on_oom_timeout,

You were CCed on the discussion
http://lkml.kernel.org/r/20150609170310.GA8990%40dhcp22.suse.cz

> but panicking would 
> only be a reasonable action if memory reserves were fully depleted.  That 
> could easily be dealt with in the page allocator so there's no timeout 
> involved.

As noted in other email. Just depletion is not a good indicator. The
system can still make a forward progress even when reserves are
depleted.

-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2015-08-25 15:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-20 21:00 David Rientjes
2015-08-20 23:10 ` Andrew Morton
2015-08-21  8:17 ` Michal Hocko
2015-08-21 13:29   ` Tetsuo Handa
2015-08-24 21:10     ` David Rientjes
2015-08-25 15:26       ` Michal Hocko [this message]
2015-08-24 21:04   ` David Rientjes
2015-08-25 14:25     ` Michal Hocko
2015-08-25 23:41       ` David Rientjes
2015-08-26  7:01         ` Michal Hocko
2015-08-26 22:23           ` David Rientjes
2015-08-27 12:41             ` Michal Hocko
2015-08-27 20:52               ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150825152650.GI6285@dhcp22.suse.cz \
    --to=mhocko@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=oleg@redhat.com \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=rientjes@google.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox