From: Michal Hocko <mhocko@kernel.org>
To: Yaowei Bai <bywxiaobai@163.com>
Cc: akpm@linux-foundation.org, mgorman@suse.de, vbabka@suse.cz,
js1304@gmail.com, hannes@cmpxchg.org,
alexander.h.duyck@redhat.com, sasha.levin@oracle.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] mm/memblock: fix memblock comment
Date: Mon, 24 Aug 2015 12:50:33 +0200 [thread overview]
Message-ID: <20150824105032.GK17078@dhcp22.suse.cz> (raw)
In-Reply-To: <1440229212-8737-3-git-send-email-bywxiaobai@163.com>
On Sat 22-08-15 15:40:12, Yaowei Bai wrote:
> 's/amd/and/'
Is this really worth it? It doesn't help grepability and just churns the
history.
>
> Signed-off-by: Yaowei Bai <bywxiaobai@163.com>
> ---
> include/linux/memblock.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/memblock.h b/include/linux/memblock.h
> index cc4b019..273aad7 100644
> --- a/include/linux/memblock.h
> +++ b/include/linux/memblock.h
> @@ -304,7 +304,7 @@ static inline void __init memblock_set_bottom_up(bool enable) {}
> static inline bool memblock_bottom_up(void) { return false; }
> #endif
>
> -/* Flags for memblock_alloc_base() amd __memblock_alloc_base() */
> +/* Flags for memblock_alloc_base() and __memblock_alloc_base() */
> #define MEMBLOCK_ALLOC_ANYWHERE (~(phys_addr_t)0)
> #define MEMBLOCK_ALLOC_ACCESSIBLE 0
>
> --
> 1.9.1
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-08-24 10:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-22 7:40 [PATCH 1/3] mm/page_alloc: fix a terrible misleading comment Yaowei Bai
2015-08-22 7:40 ` [PATCH 2/3] mm/page_alloc: add a helper function to check page before alloc/free Yaowei Bai
2015-08-24 10:47 ` Michal Hocko
2015-08-22 7:40 ` [PATCH 3/3] mm/memblock: fix memblock comment Yaowei Bai
2015-08-24 10:50 ` Michal Hocko [this message]
2015-08-24 10:44 ` [PATCH 1/3] mm/page_alloc: fix a terrible misleading comment Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150824105032.GK17078@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@redhat.com \
--cc=bywxiaobai@163.com \
--cc=hannes@cmpxchg.org \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=sasha.levin@oracle.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox