* [PATCH] list_lru: don't call list_lru_from_kmem if the list_head is empty
@ 2015-08-19 14:05 Jeff Layton
2015-08-19 14:25 ` Vladimir Davydov
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Layton @ 2015-08-19 14:05 UTC (permalink / raw)
To: Andrew Morton; +Cc: Vladimir Davydov, linux-mm, linux-kernel
If the list_head is empty then we'll have called list_lru_from_kmem
for nothing. Move that call inside of the list_empty if block.
Cc: Vladimir Davydov <vdavydov@parallels.com>
Signed-off-by: Jeff Layton <jeff.layton@primarydata.com>
---
mm/list_lru.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/list_lru.c b/mm/list_lru.c
index 909eca2c820e..e1da19fac1b3 100644
--- a/mm/list_lru.c
+++ b/mm/list_lru.c
@@ -99,8 +99,8 @@ bool list_lru_add(struct list_lru *lru, struct list_head *item)
struct list_lru_one *l;
spin_lock(&nlru->lock);
- l = list_lru_from_kmem(nlru, item);
if (list_empty(item)) {
+ l = list_lru_from_kmem(nlru, item);
list_add_tail(item, &l->list);
l->nr_items++;
spin_unlock(&nlru->lock);
@@ -118,8 +118,8 @@ bool list_lru_del(struct list_lru *lru, struct list_head *item)
struct list_lru_one *l;
spin_lock(&nlru->lock);
- l = list_lru_from_kmem(nlru, item);
if (!list_empty(item)) {
+ l = list_lru_from_kmem(nlru, item);
list_del_init(item);
l->nr_items--;
spin_unlock(&nlru->lock);
--
2.4.3
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] list_lru: don't call list_lru_from_kmem if the list_head is empty
2015-08-19 14:05 [PATCH] list_lru: don't call list_lru_from_kmem if the list_head is empty Jeff Layton
@ 2015-08-19 14:25 ` Vladimir Davydov
0 siblings, 0 replies; 2+ messages in thread
From: Vladimir Davydov @ 2015-08-19 14:25 UTC (permalink / raw)
To: Jeff Layton; +Cc: Andrew Morton, linux-mm, linux-kernel
On Wed, Aug 19, 2015 at 10:05:40AM -0400, Jeff Layton wrote:
> If the list_head is empty then we'll have called list_lru_from_kmem
> for nothing. Move that call inside of the list_empty if block.
>
> Cc: Vladimir Davydov <vdavydov@parallels.com>
> Signed-off-by: Jeff Layton <jeff.layton@primarydata.com>
Reviewed-by: Vladimir Davydov <vdavydov@parallels.com>
> ---
> mm/list_lru.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/list_lru.c b/mm/list_lru.c
> index 909eca2c820e..e1da19fac1b3 100644
> --- a/mm/list_lru.c
> +++ b/mm/list_lru.c
> @@ -99,8 +99,8 @@ bool list_lru_add(struct list_lru *lru, struct list_head *item)
> struct list_lru_one *l;
>
> spin_lock(&nlru->lock);
> - l = list_lru_from_kmem(nlru, item);
> if (list_empty(item)) {
> + l = list_lru_from_kmem(nlru, item);
> list_add_tail(item, &l->list);
> l->nr_items++;
> spin_unlock(&nlru->lock);
> @@ -118,8 +118,8 @@ bool list_lru_del(struct list_lru *lru, struct list_head *item)
> struct list_lru_one *l;
>
> spin_lock(&nlru->lock);
> - l = list_lru_from_kmem(nlru, item);
> if (!list_empty(item)) {
> + l = list_lru_from_kmem(nlru, item);
> list_del_init(item);
> l->nr_items--;
> spin_unlock(&nlru->lock);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-19 14:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-19 14:05 [PATCH] list_lru: don't call list_lru_from_kmem if the list_head is empty Jeff Layton
2015-08-19 14:25 ` Vladimir Davydov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox