linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: Wanpeng Li <wanpeng.li@hotmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 4/5] mm/hwpoison: fix refcount of THP head page in no-injection case
Date: Wed, 12 Aug 2015 08:58:59 +0000	[thread overview]
Message-ID: <20150812085859.GF32192@hori1.linux.bs1.fc.nec.co.jp> (raw)
In-Reply-To: <BLU436-SMTP127FE35D7513403A2EF15BC80700@phx.gbl>

On Mon, Aug 10, 2015 at 07:28:22PM +0800, Wanpeng Li wrote:
> Hwpoison injection takes a refcount of target page and another refcount
> of head page of THP if the target page is the tail page of a THP. However,
> current code doesn't release the refcount of head page if the THP is not 
> supported to be injected wrt hwpoison filter. 
> 
> Fix it by reducing the refcount of head page if the target page is the tail 
> page of a THP and it is not supported to be injected.
> 
> Signed-off-by: Wanpeng Li <wanpeng.li@hotmail.com>

Acked-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>

> ---
>  mm/hwpoison-inject.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/mm/hwpoison-inject.c b/mm/hwpoison-inject.c
> index 5015679..9d26fd9 100644
> --- a/mm/hwpoison-inject.c
> +++ b/mm/hwpoison-inject.c
> @@ -55,7 +55,7 @@ inject:
>  	pr_info("Injecting memory failure at pfn %#lx\n", pfn);
>  	return memory_failure(pfn, 18, MF_COUNT_INCREASED);
>  put_out:
> -	put_page(p);
> +	put_hwpoison_page(p);
>  	return 0;
>  }
>  
> -- 
> 1.7.1
> 
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2015-08-12  8:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1439206103-86829-1-git-send-email-wanpeng.li@hotmail.com>
2015-08-10 11:28 ` [PATCH v2 2/5] mm/hwpoison: fix PageHWPoison test/set race Wanpeng Li
2015-08-10 11:28 ` [PATCH v2 3/5] mm/hwpoison: introduce put_hwpoison_page to put refcount for memory error handling Wanpeng Li
2015-08-11 23:24   ` Andrew Morton
2015-08-11 23:51     ` Wanpeng Li
2015-08-12  2:30     ` Wanpeng Li
2015-08-12  8:58   ` Naoya Horiguchi
2015-08-10 11:28 ` [PATCH v2 4/5] mm/hwpoison: fix refcount of THP head page in no-injection case Wanpeng Li
2015-08-12  8:58   ` Naoya Horiguchi [this message]
2015-08-10 11:28 ` [PATCH v2 5/5] mm/hwpoison: replace most of put_page in memory error handling by put_hwpoison_page Wanpeng Li
2015-08-12  8:55   ` Naoya Horiguchi
2015-08-12  9:13     ` Wanpeng Li
2015-08-12  9:35       ` Wanpeng Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150812085859.GF32192@hori1.linux.bs1.fc.nec.co.jp \
    --to=n-horiguchi@ah.jp.nec.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=wanpeng.li@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox