[PATCH -next] mm: Fix build breakage seen if MMU_NOTIFIER is not configured

[PATCH -next] mm: Fix build breakage seen if MMU_NOTIFIER is not configured

[Guenter Roeck]

Commit 65525488fa86 ("proc: add kpageidle file") introduces code
which depends on MMU_NOTIFIER, yet the newly introduced configuration
flag does not declare that dependency. This results in the following
build failures seen if IDLE_PAGE_TRACKING is configured but MMU_NOTIFIER
is not.

fs/proc/page.c: In function 'kpageidle_clear_pte_refs_one':
fs/proc/page.c:341:4: error:
	implicit declaration of function 'pmdp_clear_young_notify'
fs/proc/page.c:347:4: error:
	implicit declaration of function 'ptep_clear_young_notify'

Fixes: 65525488fa86 ("proc: add kpageidle file")
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Andres Lagar-Cavilla <andreslc@google.com>
Cc: Vladimir Davydov <vdavydov@parallels.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 mm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/Kconfig b/mm/Kconfig
index 7e9ccb438985..b73b41c3217b 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -651,6 +651,7 @@ config DEFERRED_STRUCT_PAGE_INIT
 
 config IDLE_PAGE_TRACKING
 	bool "Enable idle page tracking"
+	depends on MMU_NOTIFIER
 	select PROC_PAGE_MONITOR
 	select PAGE_EXTENSION if !64BIT
 	help
-- 
2.1.0

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH -next] mm: Fix build breakage seen if MMU_NOTIFIER is not configured

[Vladimir Davydov]

On Mon, Jul 27, 2015 at 08:02:23AM -0700, Guenter Roeck wrote:

> fs/proc/page.c: In function 'kpageidle_clear_pte_refs_one':
> fs/proc/page.c:341:4: error:
> 	implicit declaration of function 'pmdp_clear_young_notify'
> fs/proc/page.c:347:4: error:
> 	implicit declaration of function 'ptep_clear_young_notify'

The issue has already been reported and fixed, see
http://www.spinics.net/lists/linux-mm/msg92023.html

Thanks,
Vladimir

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>