From: Michal Hocko <mhocko@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Tejun Heo <tj@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>,
Vladimir Davydov <vdavydov@parallels.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/5] memcg: export struct mem_cgroup
Date: Fri, 24 Jul 2015 10:17:10 +0200 [thread overview]
Message-ID: <20150724081710.GG4103@dhcp22.suse.cz> (raw)
In-Reply-To: <20150720114913.GG1211@dhcp22.suse.cz>
On Mon 20-07-15 13:49:13, Michal Hocko wrote:
> On Fri 17-07-15 13:19:00, Andrew Morton wrote:
[...]
> > Why were cg_proto_flags and cg_proto moved from include/net/sock.h?
>
> Because they naturally belong to memcg header file. We can keep it there
> if you prefer but I felt like sock.h is quite heavy already.
> Now that I am looking into other MEMCG_KMEM related stuff there,
> memcg_proto_active sounds like a good one to move to memcontrol.h as well.
Double checked and memcg_proto_active has only one user which lives in
memcontrol.c so it doesn't make much sense to have it in the header file
---
next prev parent reply other threads:[~2015-07-24 8:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 11:14 [PATCH 0/5] expose mem_cgroup + cleanups Michal Hocko
2015-07-15 11:14 ` [PATCH 1/5] memcg: export struct mem_cgroup Michal Hocko
2015-07-15 20:57 ` Andrew Morton
2015-07-16 7:19 ` Michal Hocko
2015-07-16 21:34 ` Andrew Morton
2015-07-16 22:56 ` Johannes Weiner
2015-07-16 23:03 ` Andrew Morton
2015-07-17 12:28 ` Johannes Weiner
2015-07-17 15:18 ` Tejun Heo
2015-07-17 20:19 ` Andrew Morton
2015-07-20 11:49 ` Michal Hocko
2015-07-24 8:17 ` Michal Hocko [this message]
2015-07-20 11:23 ` Michal Hocko
2015-07-20 22:43 ` Andrew Morton
2015-07-21 12:55 ` Michal Hocko
2015-07-15 11:14 ` [PATCH 2/5] memcg: get rid of mem_cgroup_root_css for !CONFIG_MEMCG Michal Hocko
2015-07-15 11:14 ` [PATCH 3/5] memcg: get rid of extern for functions in memcontrol.h Michal Hocko
2015-07-15 11:14 ` [PATCH 4/5] memcg: restructure mem_cgroup_can_attach() Michal Hocko
2015-07-15 11:14 ` [PATCH 5/5] memcg, tcp_kmem: check for cg_proto in sock_update_memcg Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150724081710.GG4103@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tj@kernel.org \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox