From: Peter Zijlstra <peterz@infradead.org>
To: Mel Gorman <mgorman@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Nicolai Stange <nicstange@gmail.com>,
Dave Hansen <dave.hansen@intel.com>,
Alex Ng <alexng@microsoft.com>,
Fengguang Wu <fengguang.wu@intel.com>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] mm, meminit: replace rwsem with completion
Date: Fri, 17 Jul 2015 15:12:52 +0200 [thread overview]
Message-ID: <20150717131252.GL19282@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1437135724-20110-2-git-send-email-mgorman@suse.de>
On Fri, Jul 17, 2015 at 01:22:02PM +0100, Mel Gorman wrote:
> From: Nicolai Stange <nicstange@gmail.com>
>
> Commit 0e1cc95b4cc7 ("mm: meminit: finish initialisation of struct pages
> before basic setup") introduced a rwsem to signal completion of the
> initialization workers.
>
> Lockdep complains about possible recursive locking:
> =============================================
> [ INFO: possible recursive locking detected ]
> 4.1.0-12802-g1dc51b8 #3 Not tainted
> ---------------------------------------------
> swapper/0/1 is trying to acquire lock:
> (pgdat_init_rwsem){++++.+},
> at: [<ffffffff8424c7fb>] page_alloc_init_late+0xc7/0xe6
>
> but task is already holding lock:
> (pgdat_init_rwsem){++++.+},
> at: [<ffffffff8424c772>] page_alloc_init_late+0x3e/0xe6
>
> Replace the rwsem by a completion together with an atomic
> "outstanding work counter".
>
> [peterz@infradead.org: Barrier removal on the grounds of being pointless]
> [mgorman@suse.de: Applied review feedback]
> Signed-off-by: Nicolai Stange <nicstange@gmail.com>
> Signed-off-by: Mel Gorman <mgorman@suse.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-07-17 13:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 12:22 [PATCH 0/3] Deferred memory initialisation fixes Mel Gorman
2015-07-17 12:22 ` [PATCH 1/3] mm, meminit: replace rwsem with completion Mel Gorman
2015-07-17 13:12 ` Peter Zijlstra [this message]
2015-07-17 12:22 ` [PATCH 2/3] fs, file table: Reinit files_stat.max_files after deferred memory initialisation Mel Gorman
2015-07-17 12:22 ` [PATCH 3/3] mm, meminit: Allow early_pfn_to_nid to be used during runtime Mel Gorman
2015-07-17 13:12 ` Peter Zijlstra
2015-07-17 13:17 ` Mel Gorman
2015-07-17 13:29 ` Peter Zijlstra
2015-07-17 13:39 ` Mel Gorman
2015-07-17 13:50 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150717131252.GL19282@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=alexng@microsoft.com \
--cc=dave.hansen@intel.com \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=nicstange@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox