linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin LaHaise <bcrl@kvack.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: kbuild test robot <fengguang.wu@intel.com>,
	Jeff Moyer <jmoyer@redhat.com>,
	kbuild-all@01.org, Johannes Weiner <hannes@cmpxchg.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [mmotm:master 140/321] fs/built-in.o:undefined reference to `filemap_page_mkwrite'
Date: Thu, 16 Jul 2015 15:12:58 -0400	[thread overview]
Message-ID: <20150716191258.GA22760@kvack.org> (raw)
In-Reply-To: <20150716190503.GA22146@redhat.com>

On Thu, Jul 16, 2015 at 09:05:03PM +0200, Oleg Nesterov wrote:
> Thanks!
...
> but the problem looks clear: CONFIG_MMU is not set, so we need
> a dummy filemap_page_mkwrite() along with generic_file_mmap() and
> generic_file_readonly_mmap().
> 
> I'll send the fix, but...
> 
> Benjamin, Jeff, shouldn't AIO depend on MMU? Or it can actually work even
> if CONFIG_MMU=n?

It should work when CONFIG_MMU=n, but I doubt anyone regularly attempts to 
do so (if ever).

		-ben
-- 
"Thought is the essence of where you are now."

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2015-07-16 19:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16  1:02 kbuild test robot
2015-07-16 19:05 ` Oleg Nesterov
2015-07-16 19:12   ` Benjamin LaHaise [this message]
2015-07-16 19:38     ` Oleg Nesterov
2015-07-16 19:45       ` Benjamin LaHaise
2015-07-16 20:03         ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150716191258.GA22760@kvack.org \
    --to=bcrl@kvack.org \
    --cc=akpm@linux-foundation.org \
    --cc=fengguang.wu@intel.com \
    --cc=hannes@cmpxchg.org \
    --cc=jmoyer@redhat.com \
    --cc=kbuild-all@01.org \
    --cc=linux-mm@kvack.org \
    --cc=oleg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox