From: Andrew Morton <akpm@linux-foundation.org>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: kbuild test robot <fengguang.wu@intel.com>,
Mel Gorman <mgorman@suse.de>,
kbuild-all@01.org,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: mm/page_alloc.c:247:6: warning: unused variable 'nid'
Date: Mon, 6 Jul 2015 15:05:09 -0700 [thread overview]
Message-ID: <20150706150509.48abfb09376605d611ceadbe@linux-foundation.org> (raw)
In-Reply-To: <20150704181008.GA1374@node.dhcp.inet.fi>
On Sat, 4 Jul 2015 21:10:08 +0300 "Kirill A. Shutemov" <kirill@shutemov.name> wrote:
> On Sat, Jul 04, 2015 at 05:26:47PM +0800, kbuild test robot wrote:
> > tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head: 14a6f1989dae9445d4532941bdd6bbad84f4c8da
> > commit: 3b242c66ccbd60cf47ab0e8992119d9617548c23 x86: mm: enable deferred struct page initialisation on x86-64
> > date: 3 days ago
> > config: x86_64-randconfig-x006-201527 (attached as .config)
> > reproduce:
> > git checkout 3b242c66ccbd60cf47ab0e8992119d9617548c23
> > # save the attached .config to linux build tree
> > make ARCH=x86_64
> >
> > All warnings (new ones prefixed by >>):
> >
> > mm/page_alloc.c: In function 'early_page_uninitialised':
> > >> mm/page_alloc.c:247:6: warning: unused variable 'nid' [-Wunused-variable]
> > int nid = early_pfn_to_nid(pfn);
>
> We can silence the warning with something like patch below. But I'm not
> sure it worth it.
>
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index 754c25966a0a..746a6a7b0535 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -911,7 +911,7 @@ extern char numa_zonelist_order[];
> #ifndef CONFIG_NEED_MULTIPLE_NODES
>
> extern struct pglist_data contig_page_data;
> -#define NODE_DATA(nid) (&contig_page_data)
> +#define NODE_DATA(nid) ((void)nid, &contig_page_data)
> #define NODE_MEM_MAP(nid) mem_map
>
> #else /* CONFIG_NEED_MULTIPLE_NODES */
Sigh. Macros do suck. If NODE_DATA was a regular old C function this
warning wouldn't occur. Problem is, we should then rename it to
"node_data" and that would require 246 edits.
I suppose we could compromise and do
static inline struct pglist_data *NODE_DATA(int nid)
?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-07-06 22:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-04 9:26 kbuild test robot
2015-07-04 18:10 ` Kirill A. Shutemov
2015-07-06 22:05 ` Andrew Morton [this message]
2015-07-07 8:12 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150706150509.48abfb09376605d611ceadbe@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=kirill@shutemov.name \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox