From: Mel Gorman <mgorman@suse.de>
To: Nicolai Stange <nicstange@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
David Rientjes <rientjes@google.com>,
Alexander Duyck <alexander.h.duyck@redhat.com>,
Sasha Levin <sasha.levin@oracle.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/page_alloc: deferred meminit: replace rwsem with completion
Date: Mon, 6 Jul 2015 09:21:43 +0100 [thread overview]
Message-ID: <20150706082143.GG6812@suse.de> (raw)
In-Reply-To: <87k2uecf6t.fsf@gmail.com>
On Mon, Jul 06, 2015 at 02:17:30AM +0200, Nicolai Stange wrote:
> Commit 0e1cc95b4cc7
> ("mm: meminit: finish initialisation of struct pages before basic setup")
> introduced a rwsem to signal completion of the initialization workers.
>
> Lockdep complains about possible recursive locking:
> =============================================
> [ INFO: possible recursive locking detected ]
> 4.1.0-12802-g1dc51b8 #3 Not tainted
> ---------------------------------------------
> swapper/0/1 is trying to acquire lock:
> (pgdat_init_rwsem){++++.+},
> at: [<ffffffff8424c7fb>] page_alloc_init_late+0xc7/0xe6
>
> but task is already holding lock:
> (pgdat_init_rwsem){++++.+},
> at: [<ffffffff8424c772>] page_alloc_init_late+0x3e/0xe6
>
> Replace the rwsem by a completion together with an atomic
> "outstanding work counter".
>
> Signed-off-by: Nicolai Stange <nicstange@gmail.com>
Acked-by: Mel Gorman <mgorman@suse.de>
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-07-06 8:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 0:17 Nicolai Stange
2015-07-06 8:21 ` Mel Gorman [this message]
2015-07-06 15:11 ` Nicolai Stange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150706082143.GG6812@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=nicstange@gmail.com \
--cc=rientjes@google.com \
--cc=sasha.levin@oracle.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox