From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yk0-f180.google.com (mail-yk0-f180.google.com [209.85.160.180]) by kanga.kvack.org (Postfix) with ESMTP id EEE1E6B0032 for ; Wed, 17 Jun 2015 00:15:36 -0400 (EDT) Received: by ykdr198 with SMTP id r198so30581043ykd.3 for ; Tue, 16 Jun 2015 21:15:36 -0700 (PDT) Received: from mx0b-00082601.pphosted.com (mx0b-00082601.pphosted.com. [67.231.153.30]) by mx.google.com with ESMTPS id 66si1128438yhq.49.2015.06.16.21.15.36 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 16 Jun 2015 21:15:36 -0700 (PDT) Date: Tue, 16 Jun 2015 21:15:24 -0700 From: Martin KaFai Lau Subject: Re: [RFC NEXT] mm: Fix suspicious RCU usage at kernel/sched/core.c:7318 Message-ID: <20150617041524.GD3958923@devbig242.prn2.facebook.com> References: <1434403518-5308-1-git-send-email-Larry.Finger@lwfinger.net> <20150616210720.GC3958923@devbig242.prn2.facebook.com> <5580DED0.3060002@lwfinger.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <5580DED0.3060002@lwfinger.net> Sender: owner-linux-mm@kvack.org List-ID: To: Larry Finger Cc: Tejun Heo , Catalin Marinas , Christoph Lameter , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Kernel Team On Tue, Jun 16, 2015 at 09:43:28PM -0500, Larry Finger wrote: > On 06/16/2015 04:07 PM, Martin KaFai Lau wrote: > >On Mon, Jun 15, 2015 at 04:25:18PM -0500, Larry Finger wrote: > >>Additional backtrace lines are truncated. In addition, the above splat is > >>followed by several "BUG: sleeping function called from invalid context > >>at mm/slub.c:1268" outputs. As suggested by Martin KaFai Lau, these are the > >>clue to the fix. Routine kmemleak_alloc_percpu() always uses GFP_KERNEL > >>for its allocations, whereas it should use the value input to pcpu_alloc(). > >Just a minor nit, 'kmemleak_alloc_percpu() should follow the gfp from > >per_alloc()' may be a more accurate title to describe the patch. > > Do you mean that the subject should be changed? Yes A typo in my last response: s/per_alloc/pcpu_alloc/ --Martin -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org