From: Michal Hocko <mhocko@suse.cz>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Darren Hart <dvhart@infradead.org>,
Hans de Goede <hdegoede@redhat.com>,
Ben Skeggs <bskeggs@redhat.com>,
Stuart Hayes <stuart_hayes@dell.com>,
Matthew Garrett <mjg@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
platform-driver-x86@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: Possible broken MM code in dell-laptop.c?
Date: Tue, 16 Jun 2015 09:43:09 +0200 [thread overview]
Message-ID: <20150616074308.GB24296@dhcp22.suse.cz> (raw)
In-Reply-To: <20150616071523.GB5863@pali>
On Tue 16-06-15 09:15:23, Pali Rohar wrote:
[...]
> Michal, thank you for explaining this situation!
>
> Darren, I will prepare patch which will fix code and use __free_page().
>
> (Btw, execution on fail_rfkill label caused kernel panic)
I am sorry, I could have made it more clear in the very first email.
A panic is to be expected because free_page will translate the given
address to a struct page* but this is what the code gave it. So an
unrelated struct page would be freed (or maybe an invalid one).
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-06-16 7:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-14 9:05 Pali Rohár
2015-06-15 20:36 ` Darren Hart
2015-06-15 20:42 ` Pali Rohár
2015-06-16 10:12 ` Pavel Machek
2015-06-15 21:18 ` Michal Hocko
2015-06-15 21:27 ` Pali Rohár
2015-06-16 6:33 ` Michal Hocko
2015-06-16 7:15 ` Pali Rohár
2015-06-16 7:43 ` Michal Hocko [this message]
2015-06-17 3:43 ` Darren Hart
2015-06-17 7:19 ` Michal Hocko
2015-06-18 21:14 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150616074308.GB24296@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=bskeggs@redhat.com \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mjg@redhat.com \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stuart_hayes@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox