From: Shaohua Li <shli@fb.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Chris Mason <clm@fb.com>,
netdev@vger.kernel.org, davem@davemloft.net, Kernel-team@fb.com,
Eric Dumazet <edumazet@google.com>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org
Subject: Re: [RFC] net: use atomic allocation for order-3 page allocation
Date: Thu, 11 Jun 2015 15:01:15 -0700 [thread overview]
Message-ID: <20150611220115.GA448912@devbig257.prn2.facebook.com> (raw)
In-Reply-To: <1434059786.27504.58.camel@edumazet-glaptop2.roam.corp.google.com>
On Thu, Jun 11, 2015 at 02:56:26PM -0700, Eric Dumazet wrote:
> On Thu, 2015-06-11 at 14:45 -0700, Shaohua Li wrote:
>
> > This is exactly what the patch try to do. Atomic 32k allocation will
> > fail with memory pressure, kswapd is waken up to do compaction and we
> > fallback to 4k.
>
> Read your changelog, then read what you just wrote.
>
> Your changelog said :
>
> 'compaction will not be triggered and we will fallback to order-0
> immediately.'
>
> Now you tell me that compaction is started.
>
> What is the truth ?
>
> Please make sure changelog is precise, this would avoid many mails.
Ah, ok. I mean direct compaction isn't triggered, kswapd is still waken
up to do compaction. I'll update the changelog.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-06-11 22:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 22:27 [RFC v2] " Shaohua Li
2015-06-11 20:48 ` [RFC] " Eric Dumazet
2015-06-11 21:16 ` Chris Mason
2015-06-11 21:22 ` Eric Dumazet
2015-06-11 21:45 ` Shaohua Li
2015-06-11 21:56 ` Eric Dumazet
2015-06-11 22:01 ` Shaohua Li [this message]
2015-06-11 22:18 ` Chris Mason
2015-06-11 22:55 ` Eric Dumazet
2015-06-11 21:35 ` Debabrata Banerjee
2015-06-11 22:18 ` David Miller
2015-06-12 9:25 ` Vlastimil Babka
2015-06-11 21:25 ` Debabrata Banerjee
2015-06-11 21:28 ` Debabrata Banerjee
2015-06-12 9:34 ` Vlastimil Babka
2015-06-11 22:53 ` [RFC v2] " Eric Dumazet
2015-06-11 23:32 ` Shaohua Li
2015-06-11 23:38 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150611220115.GA448912@devbig257.prn2.facebook.com \
--to=shli@fb.com \
--cc=Kernel-team@fb.com \
--cc=clm@fb.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox