From: Michal Hocko <mhocko@suse.cz>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hugetlb: Do not account hugetlb pages as NR_FILE_PAGES
Date: Fri, 22 May 2015 16:28:24 +0200 [thread overview]
Message-ID: <20150522142824.GG5109@dhcp22.suse.cz> (raw)
In-Reply-To: <20150522142143.GF5109@dhcp22.suse.cz>
On Fri 22-05-15 16:21:43, Michal Hocko wrote:
> On Thu 21-05-15 13:09:09, Johannes Weiner wrote:
[...]
> > This makes a lot of sense to me. The only thing I worry about is the
> > proliferation of PageHuge(), a function call, in relatively hot paths.
>
> I've tried that (see the patch below) but it enlarged the code by almost
> 1k
> text data bss dec hex filename
> 510323 74273 44440 629036 9992c mm/built-in.o.before
> 511248 74273 44440 629961 99cc9 mm/built-in.o.after
>
> I am not sure the code size increase is worth it. Maybe we can reduce
> the check to only PageCompound(page) as huge pages are no in the page
> cache (yet).
Just to prevent from confusion. I means to reduce the check only for
this particular case. But that is probably not worth the troubles
either...
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-05-22 14:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 13:27 Michal Hocko
2015-05-21 13:52 ` Mel Gorman
2015-05-21 16:18 ` Mike Kravetz
2015-05-22 6:01 ` Michal Hocko
2015-05-21 17:09 ` Johannes Weiner
2015-05-22 14:21 ` Michal Hocko
2015-05-22 14:28 ` Michal Hocko [this message]
2015-05-22 14:35 ` Mel Gorman
2015-05-25 15:24 ` Vlastimil Babka
2015-06-02 9:25 ` Michal Hocko
2015-06-02 9:33 ` Vlastimil Babka
2015-06-02 9:38 ` Michal Hocko
2015-06-02 10:00 ` Michal Hocko
2015-05-22 5:09 ` Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150522142824.GG5109@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox