From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Mel Gorman <mgorman@suse.de>,
Johannes Weiner <hannes@cmpxchg.org>,
Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH 1/3] mm/page_alloc: don't break highest order freepage if steal
Date: Tue, 19 May 2015 16:44:30 +0900 [thread overview]
Message-ID: <20150519074429.GC12092@js1304-P5Q-DELUXE> (raw)
In-Reply-To: <5551B1CB.7070301@suse.cz>
On Tue, May 12, 2015 at 09:54:51AM +0200, Vlastimil Babka wrote:
> On 05/12/2015 09:51 AM, Vlastimil Babka wrote:
> >> {
> >> struct page *page;
> >>+ bool steal_fallback;
> >>
> >>-retry_reserve:
> >>+retry:
> >> page = __rmqueue_smallest(zone, order, migratetype);
> >>
> >> if (unlikely(!page) && migratetype != MIGRATE_RESERVE) {
> >> if (migratetype == MIGRATE_MOVABLE)
> >> page = __rmqueue_cma_fallback(zone, order);
> >>
> >>- if (!page)
> >>- page = __rmqueue_fallback(zone, order, migratetype);
> >>+ if (page)
> >>+ goto out;
> >>+
> >>+ steal_fallback = __rmqueue_fallback(zone, order, migratetype);
>
> Oh and the variable can be probably replaced by calling
> __rmqueue_fallback directly in the if() below.
Will do.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-05-19 7:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 7:23 Joonsoo Kim
2015-04-27 7:23 ` [PATCH 2/3] mm/page_alloc: stop fallback allocation if we already get some freepage Joonsoo Kim
2015-05-12 8:36 ` Vlastimil Babka
2015-05-19 7:47 ` Joonsoo Kim
2015-04-27 7:23 ` [RFC PATCH 3/3] mm: support active anti-fragmentation algorithm Joonsoo Kim
2015-04-27 8:29 ` Mel Gorman
2015-04-28 7:45 ` Joonsoo Kim
2015-05-12 9:01 ` Vlastimil Babka
2015-05-19 8:04 ` Joonsoo Kim
2015-04-27 8:08 ` [PATCH 1/3] mm/page_alloc: don't break highest order freepage if steal Mel Gorman
2015-04-27 8:42 ` Joonsoo Kim
2015-05-12 7:57 ` Vlastimil Babka
2015-05-12 7:51 ` Vlastimil Babka
2015-05-12 7:54 ` Vlastimil Babka
2015-05-19 7:44 ` Joonsoo Kim [this message]
2015-05-19 7:44 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150519074429.GC12092@js1304-P5Q-DELUXE \
--to=iamjoonsoo.kim@lge.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=riel@redhat.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox