linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Anisse Astier <anisse@astier.eu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Mel Gorman <mgorman@suse.de>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	David Rientjes <rientjes@google.com>,
	Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Peter Zijlstra <peterz@infradead.org>,
	PaX Team <pageexec@freemail.hu>,
	Brad Spengler <spender@grsecurity.net>,
	Kees Cook <keescook@chromium.org>,
	Andi Kleen <andi@firstfloor.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <len.brown@intel.com>,
	linux-mm@kvack.org, Linux PM list <linux-pm@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 2/3] mm/page_alloc.c: add config option to sanitize freed pages
Date: Mon, 18 May 2015 15:02:13 +0200	[thread overview]
Message-ID: <20150518130213.GA771@amd> (raw)
In-Reply-To: <CALUN=qLHfz5DnSKfaRf833eewOM65FNtxybY9Xw9sp1=qq+Zqw@mail.gmail.com>

On Mon 2015-05-18 14:41:19, Anisse Astier wrote:
> On Mon, May 18, 2015 at 1:21 PM, Pavel Machek <pavel@ucw.cz> wrote:
> > On Thu 2015-05-14 16:19:47, Anisse Astier wrote:
> >> This new config option will sanitize all freed pages. This is a pretty
> >> low-level change useful to track some cases of use-after-free, help
> >> kernel same-page merging in VM environments, and counter a few info
> >> leaks.
> >
> > Could you document the "few info leaks"? We may want to fix them for
> > !SANTIZE_FREED_PAGES case, too...
> >
> 
> I wish I could; I'd be sending patches for those info leaks, too.
> 
> What I meant is that this feature can also be used as a general
> protection mechanism against a certain class of info leaks; for
> example, some drivers allocating pages that were previously used by
> other subsystems, and then sending structures to userspace that
> contain padding or uninitialized fields, leaking kernel pointers.
> Having all pages cleared unconditionally can help a bit in some cases
> (hence "a few"), but it's of course not an end-all solution.

Ok. So there is class of errors where this helps, but you are not
aware of any such errors in kernel, so you can't fix them... Right?

> I'll edit the commit and kconfig messages to be more precise.

Thanks,
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2015-05-18 13:02 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-14 14:19 [PATCH v4 0/3] Sanitizing " Anisse Astier
2015-05-14 14:19 ` [PATCH v4 1/3] PM / Hibernate: prepare for SANITIZE_FREED_PAGES Anisse Astier
2015-05-16  0:28   ` Rafael J. Wysocki
2015-05-18 10:23     ` Anisse Astier
2015-05-19 23:46       ` Rafael J. Wysocki
2015-05-20 11:45         ` PaX Team
2015-05-20 12:07           ` Anisse Astier
2015-05-21  1:11             ` Rafael J. Wysocki
2015-05-20 11:57         ` Anisse Astier
2015-05-14 14:19 ` [PATCH v4 2/3] mm/page_alloc.c: add config option to sanitize freed pages Anisse Astier
2015-05-18 11:21   ` Pavel Machek
2015-05-18 12:41     ` Anisse Astier
2015-05-18 13:02       ` Pavel Machek [this message]
2015-05-18 13:04         ` Anisse Astier
2015-05-19  1:58           ` yalin wang
2015-05-20 12:27             ` Anisse Astier
2015-05-14 14:19 ` [PATCH v4 3/3] mm: Add debug code for SANITIZE_FREED_PAGES Anisse Astier
2015-05-19 12:46 ` [PATCH v4 0/3] Sanitizing freed pages Mel Gorman
2015-05-19 13:35   ` One Thousand Gnomes
2015-05-19 13:56     ` Mel Gorman
2015-05-19 20:59   ` PaX Team
2015-05-20 12:24   ` Anisse Astier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150518130213.GA771@amd \
    --to=pavel@ucw.cz \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=anisse@astier.eu \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=keescook@chromium.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=pageexec@freemail.hu \
    --cc=peterz@infradead.org \
    --cc=rientjes@google.com \
    --cc=rjw@rjwysocki.net \
    --cc=spender@grsecurity.net \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox