From: Michal Hocko <mhocko@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: Nikolay Borisov <kernel@kyup.com>,
cgroups@vger.kernel.org, hannes@cmpxchg.org, linux-mm@kvack.org
Subject: Re: Possible bug - LTP failure for memcg
Date: Thu, 14 May 2015 14:12:48 +0200 [thread overview]
Message-ID: <20150514121248.GG6799@dhcp22.suse.cz> (raw)
In-Reply-To: <20150514120142.GG5066@rei.suse.de>
On Thu 14-05-15 14:01:42, Cyril Hrubis wrote:
> Hi!
> > > The previous testcases does exactly this but moves the process to the
> > > parent with:
> > >
> > > echo $pid > ../tasks
> > >
> > > Before it tries the force_empty and expects it to succeed.
> > >
> > > Was this some old implementation limitation that has been lifted
> > > meanwhile?
> >
> > OK, now I remember... f61c42a7d911 ("memcg: remove tasks/children test
> > from mem_cgroup_force_empty()") which goes back to 3.16. So the test
> > case is invalid.
>
> Then please send a patch to remove the test.
I think we can still fix both tescases and expect not to fail with
regular mmap but fail it with unreclaimable memory (e.g. disallow
swapout or use mlock).
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-05-14 12:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 15:29 Nikolay Borisov
2015-05-14 9:21 ` Michal Hocko
2015-05-14 9:23 ` Michal Hocko
2015-05-14 10:35 ` Cyril Hrubis
2015-05-14 11:31 ` Michal Hocko
2015-05-14 12:36 ` Cyril Hrubis
2015-05-14 10:31 ` Cyril Hrubis
2015-05-14 11:56 ` Michal Hocko
2015-05-14 12:01 ` Cyril Hrubis
2015-05-14 12:12 ` Michal Hocko [this message]
2015-05-14 12:38 ` Cyril Hrubis
2015-05-14 14:30 ` Michal Hocko
2015-05-14 14:44 ` Cyril Hrubis
2015-05-14 14:49 ` Michal Hocko
2015-05-14 15:27 ` Cyril Hrubis
2015-05-14 12:09 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150514121248.GG6799@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=cgroups@vger.kernel.org \
--cc=chrubis@suse.cz \
--cc=hannes@cmpxchg.org \
--cc=kernel@kyup.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox