From: Michal Hocko <mhocko@suse.cz>
To: Nikolay Borisov <kernel@kyup.com>
Cc: cgroups@vger.kernel.org, hannes@cmpxchg.org, linux-mm@kvack.org
Subject: Re: Possible bug - LTP failure for memcg
Date: Thu, 14 May 2015 14:09:26 +0200 [thread overview]
Message-ID: <20150514120926.GF6799@dhcp22.suse.cz> (raw)
In-Reply-To: <55536DC9.90200@kyup.com>
On Wed 13-05-15 18:29:13, Nikolay Borisov wrote:
[...]
> memcg_function_test 22 TFAIL : ltpapicmd.c:190: input=4095,
> limit_in_bytes=0
> memcg_function_test 23 TFAIL : ltpapicmd.c:190: input=4097,
> limit_in_bytes=4096
> memcg_function_test 24 TFAIL : ltpapicmd.c:190: input=1,
> limit_in_bytes=0
Before we go and fix these test cases. Do they make any sense at all?
Why should anybody even care that the limit is in page units? I do not
see anything like that mentioned in the documentation. Sure having
the limit in page size units makes a lot of sense from the
implementation POV but should userspace care? Would something break if
we change internals and allow also !page_aligned values? I have hard
time to imagine that.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2015-05-14 12:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 15:29 Nikolay Borisov
2015-05-14 9:21 ` Michal Hocko
2015-05-14 9:23 ` Michal Hocko
2015-05-14 10:35 ` Cyril Hrubis
2015-05-14 11:31 ` Michal Hocko
2015-05-14 12:36 ` Cyril Hrubis
2015-05-14 10:31 ` Cyril Hrubis
2015-05-14 11:56 ` Michal Hocko
2015-05-14 12:01 ` Cyril Hrubis
2015-05-14 12:12 ` Michal Hocko
2015-05-14 12:38 ` Cyril Hrubis
2015-05-14 14:30 ` Michal Hocko
2015-05-14 14:44 ` Cyril Hrubis
2015-05-14 14:49 ` Michal Hocko
2015-05-14 15:27 ` Cyril Hrubis
2015-05-14 12:09 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150514120926.GF6799@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kernel@kyup.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox