Re: [PATCH v4 0/3] tracing: add trace event for memory-failure

[Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>]

On Wed, Apr 29, 2015 at 07:14:27PM +0800, Xie XiuQi wrote:
> Hi Naoya,
> 
> Could you help to review and applied this series if possible.

Sorry for late response, I was offline for several days due to national
holidays.

This patchset is good to me, but I'm not sure which path it should go through.
Ordinarily, memory-failure patches go to linux-mm, but patch 3 depends on
TRACE_DEFINE_ENUM patches, so this can go to linux-next directly, or go to
linux-mm with depending patches.

Steven, Andrew, which way do you like?

Thanks,
Naoya Horiguchi

> Thanks,
> Xie XiuQi
> 
> On 2015/4/20 16:44, Xie XiuQi wrote:
> > RAS user space tools like rasdaemon which base on trace event, could
> > receive mce error event, but no memory recovery result event. So, I
> > want to add this event to make this scenario complete.
> > 
> > This patchset add a event at ras group for memory-failure.
> > 
> > The output like below:
> > #  tracer: nop
> > #
> > #  entries-in-buffer/entries-written: 2/2   #P:24
> > #
> > #                               _-----=> irqs-off
> > #                              / _----=> need-resched
> > #                             | / _---=> hardirq/softirq
> > #                             || / _--=> preempt-depth
> > #                             ||| /     delay
> > #            TASK-PID   CPU#  ||||    TIMESTAMP  FUNCTION
> > #               | |       |   ||||       |         |
> >        mce-inject-13150 [001] ....   277.019359: memory_failure_event: pfn 0x19869: recovery action for free buddy page: Delayed
> > 
> > --
> > v3->v4:
> >  - rebase on top of latest linux-next
> >  - update comments as Naoya's suggestion
> >  - add #ifdef CONFIG_MEMORY_FAILURE for this trace event
> >  - change type of action_result's param 3 to enum
> > 
> > v2->v3:
> >  - rebase on top of linux-next
> >  - based on Steven Rostedt's "tracing: Add TRACE_DEFINE_ENUM() macro
> >    to map enums to their values" patch set v1.
> > 
> > v1->v2:
> >  - Comment update
> >  - Just passing 'result' instead of 'action_name[result]',
> >    suggested by Steve. And hard coded there because trace-cmd
> >    and perf do not have a way to process enums.
> > 
> > Xie XiuQi (3):
> >   memory-failure: export page_type and action result
> >   memory-failure: change type of action_result's param 3 to enum
> >   tracing: add trace event for memory-failure
> > 
> >  include/linux/mm.h      |  34 ++++++++++
> >  include/ras/ras_event.h |  85 ++++++++++++++++++++++++
> >  mm/memory-failure.c     | 172 ++++++++++++++++++++----------------------------
> >  3 files changed, 190 insertions(+), 101 deletions(-)
> > 
> 
> 
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>