From: Andrew Morton <akpm@linux-foundation.org>
To: Tony Luck <tony.luck@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/3] mm/memblock: Add extra "flag" to memblock to allow selection of memory based on attribute
Date: Wed, 6 May 2015 16:29:29 -0700 [thread overview]
Message-ID: <20150506162929.f97cf487bd41686325f9da2f@linux-foundation.org> (raw)
In-Reply-To: <ff806a70c38aa2cf02a923a47298d40e54082d11.1430772743.git.tony.luck@intel.com>
On Wed, 29 Apr 2015 11:31:24 -0700 Tony Luck <tony.luck@intel.com> wrote:
> No functional changes
>
> ...
>
> --- a/include/linux/memblock.h
> +++ b/include/linux/memblock.h
> @@ -61,7 +61,7 @@ extern bool movable_node_enabled;
>
> phys_addr_t memblock_find_in_range_node(phys_addr_t size, phys_addr_t align,
> phys_addr_t start, phys_addr_t end,
> - int nid);
> + int nid, u32 flag);
Sometimes this is called "flag", other times it is called "flags". Can
we please be consistent? "flags" seems to be the way to go.
Also, memblock_region.flags has type unsigned long, but you've used
u32. ulong seems better.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-05-06 23:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 20:52 [PATCH 0/3] Find mirrored memory, use for boot time allocations Tony Luck
2015-02-03 22:38 ` [PATCH 2/3] mm/memblock: Allocate boot time data structures from mirrored memory Tony Luck
2015-05-06 23:30 ` Andrew Morton
2015-05-07 17:41 ` Tony Luck
2015-05-07 21:24 ` Tony Luck
2015-05-07 21:30 ` Andrew Morton
2015-02-03 22:40 ` [PATCH 3/3] x86, mirror: x86 enabling - find mirrored memory ranges Tony Luck
2015-05-06 23:30 ` Andrew Morton
2015-04-29 18:31 ` [PATCH 1/3] mm/memblock: Add extra "flag" to memblock to allow selection of memory based on attribute Tony Luck
2015-05-06 23:29 ` Andrew Morton [this message]
2015-05-06 23:29 ` [PATCH 0/3] Find mirrored memory, use for boot time allocations Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150506162929.f97cf487bd41686325f9da2f@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox