tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: b79013b2449c23f1f505bdf39c5a6c330338b244 commit: f8224aa5a0a4627926019bba7511926393fbee3b mm, compaction: do not recheck suitable_migration_target under lock date: 6 months ago config: x86_64-randconfig-ib0-04141359 (attached as .config) reproduce: git checkout f8224aa5a0a4627926019bba7511926393fbee3b # save the attached .config to linux build tree make ARCH=x86_64 All warnings: >> mm/compaction.c:250:13: warning: 'suitable_migration_target' defined but not used [-Wunused-function] static bool suitable_migration_target(struct page *page) ^ vim +/suitable_migration_target +250 mm/compaction.c be976572 Vlastimil Babka 2014-06-04 234 static inline bool compact_should_abort(struct compact_control *cc) be976572 Vlastimil Babka 2014-06-04 235 { be976572 Vlastimil Babka 2014-06-04 236 /* async compaction aborts if contended */ be976572 Vlastimil Babka 2014-06-04 237 if (need_resched()) { be976572 Vlastimil Babka 2014-06-04 238 if (cc->mode == MIGRATE_ASYNC) { be976572 Vlastimil Babka 2014-06-04 239 cc->contended = true; be976572 Vlastimil Babka 2014-06-04 240 return true; be976572 Vlastimil Babka 2014-06-04 241 } be976572 Vlastimil Babka 2014-06-04 242 be976572 Vlastimil Babka 2014-06-04 243 cond_resched(); be976572 Vlastimil Babka 2014-06-04 244 } be976572 Vlastimil Babka 2014-06-04 245 be976572 Vlastimil Babka 2014-06-04 246 return false; be976572 Vlastimil Babka 2014-06-04 247 } be976572 Vlastimil Babka 2014-06-04 248 f40d1e42 Mel Gorman 2012-10-08 249 /* Returns true if the page is within a block suitable for migration to */ f40d1e42 Mel Gorman 2012-10-08 @250 static bool suitable_migration_target(struct page *page) f40d1e42 Mel Gorman 2012-10-08 251 { 7d348b9e Joonsoo Kim 2014-04-07 252 /* If the page is a large free page, then disallow migration */ f40d1e42 Mel Gorman 2012-10-08 253 if (PageBuddy(page) && page_order(page) >= pageblock_order) 7d348b9e Joonsoo Kim 2014-04-07 254 return false; f40d1e42 Mel Gorman 2012-10-08 255 f40d1e42 Mel Gorman 2012-10-08 256 /* If the block is MIGRATE_MOVABLE or MIGRATE_CMA, allow migration */ 7d348b9e Joonsoo Kim 2014-04-07 257 if (migrate_async_suitable(get_pageblock_migratetype(page))) f40d1e42 Mel Gorman 2012-10-08 258 return true; :::::: The code at line 250 was first introduced by commit :::::: f40d1e42bb988d2a26e8e111ea4c4c7bac819b7e mm: compaction: acquire the zone->lock as late as possible :::::: TO: Mel Gorman :::::: CC: Linus Torvalds --- 0-DAY kernel test infrastructure Open Source Technology Center http://lists.01.org/mailman/listinfo/kbuild Intel Corporation