From: Christoph Hellwig <hch@lst.de>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, Ming Lei <tom.leiming@gmail.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Roger Pau Monn?? <roger.pau@citrix.com>,
Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@redhat.com>, Neil Brown <neilb@suse.de>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>,
David Sterba <dsterba@suse.cz>, Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Changman Lee <cm224.lee@samsung.com>,
Steven Whitehouse <swhiteho@redhat.com>,
Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Mel Gorman <mgorman@suse.de>,
Trond Myklebust <trond.myklebust@primarydata.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
Dave Chinner <david@fromorbit.com>,
xfs@oss.sgi.com, Christoph Hellwig <hch@lst.de>,
Weston Andros Adamson <dros@primarydata.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Sagi Grimberg <sagig@mellanox.com>, Tejun Heo <tj@kernel.org>,
Fabian Frederick <fabf@skynet.be>,
Matthew Wilcox <matthew.r.wilcox@intel.com>,
Ming Lei <ming.lei@canonical.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Wang Sheng-Hui <shhuiw@gmail.com>, Michal Hocko <mhocko@suse.cz>,
Joe Perches <joe@perches.com>, Miklos Szeredi <mszeredi@suse.cz>,
Namjae Jeon <namjae.jeon@samsung.com>,
Mark Rustad <mark.d.rustad@intel.com>,
Jianyu Zhan <nasa4836@gmail.com>,
Fengguang Wu <fengguang.wu@intel.com>,
Vladimir Davydov <vdavydov@parallels.com>,
Vlastimil Babka <vbabka@suse.cz>,
Suleiman Souhlal <suleiman@google.com>,
linux-kernel@vger.kernel.org, dm-devel@redhat.com,
xen-devel@lists.xenproject.org, linux-raid@vger.kernel.org,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-aio@kvack.org,
linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
linux-nfs@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 2/2][v2] blk-plug: don't flush nested plug lists
Date: Wed, 8 Apr 2015 18:13:55 +0200 [thread overview]
Message-ID: <20150408161355.GA16052@lst.de> (raw)
In-Reply-To: <x49wq1nrcoe.fsf_-_@segfault.boston.devel.redhat.com>
This looks good, but without the blk_finish_plug argument we're bound
to grow programming mistakes where people forget it. Any chance we
could have annotations similar to say rcu_read_lock/rcu_read_unlock
or the spinlocks so that sparse warns about it?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-04-08 16:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1428347694-17704-1-git-send-email-jmoyer@redhat.com>
[not found] ` <1428347694-17704-2-git-send-email-jmoyer@redhat.com>
2015-04-07 18:55 ` Jeff Moyer
2015-04-08 16:13 ` Christoph Hellwig [this message]
2015-04-08 23:02 ` Dave Chinner
2015-04-09 0:54 ` Dave Chinner
2015-04-10 21:50 ` Jeff Moyer
2015-04-11 4:11 ` [f2fs-dev] " nick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150408161355.GA16052@lst.de \
--to=hch@lst.de \
--cc=adilger.kernel@dilger.ca \
--cc=agk@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=anna.schumaker@netapp.com \
--cc=axboe@kernel.dk \
--cc=clm@fb.com \
--cc=cluster-devel@redhat.com \
--cc=cm224.lee@samsung.com \
--cc=david@fromorbit.com \
--cc=dm-devel@redhat.com \
--cc=dros@primarydata.com \
--cc=dsterba@suse.cz \
--cc=fabf@skynet.be \
--cc=fengguang.wu@intel.com \
--cc=hannes@cmpxchg.org \
--cc=jaegeuk@kernel.org \
--cc=jbacik@fb.com \
--cc=jmoyer@redhat.com \
--cc=joe@perches.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-aio@kvack.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mark.d.rustad@intel.com \
--cc=martin.petersen@oracle.com \
--cc=matthew.r.wilcox@intel.com \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=mikulas@artax.karlin.mff.cuni.cz \
--cc=ming.lei@canonical.com \
--cc=mszeredi@suse.cz \
--cc=nab@linux-iscsi.org \
--cc=namjae.jeon@samsung.com \
--cc=nasa4836@gmail.com \
--cc=neilb@suse.de \
--cc=riel@redhat.com \
--cc=roger.pau@citrix.com \
--cc=sagig@mellanox.com \
--cc=shhuiw@gmail.com \
--cc=snitzer@redhat.com \
--cc=suleiman@google.com \
--cc=swhiteho@redhat.com \
--cc=target-devel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=tom.leiming@gmail.com \
--cc=trond.myklebust@primarydata.com \
--cc=tytso@mit.edu \
--cc=vbabka@suse.cz \
--cc=vdavydov@parallels.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xen-devel@lists.xenproject.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox