From: Andrew Morton <akpm@linux-foundation.org>
To: Roman Pen <r.peniaev@gmail.com>
Cc: Eric Dumazet <edumazet@google.com>,
David Rientjes <rientjes@google.com>,
WANG Chao <chaowang@redhat.com>,
Fabian Frederick <fabf@skynet.be>,
Christoph Lameter <cl@linux.com>, Gioh Kim <gioh.kim@lge.com>,
Rob Jones <rob.jones@codethink.co.uk>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [RFC v2 1/3] mm/vmalloc: fix possible exhaustion of vmalloc space caused by vm_map_ram allocator
Date: Tue, 24 Mar 2015 15:00:54 -0700 [thread overview]
Message-ID: <20150324150054.a9050b7814860790e1d9b0d0@linux-foundation.org> (raw)
In-Reply-To: <1426773881-5757-2-git-send-email-r.peniaev@gmail.com>
On Thu, 19 Mar 2015 23:04:39 +0900 Roman Pen <r.peniaev@gmail.com> wrote:
> If suitable block can't be found, new block is allocated and put into a head
> of a free list, so on next iteration this new block will be found first.
>
> ...
>
> Cc: stable@vger.kernel.org
>
> ...
>
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -837,7 +837,7 @@ static struct vmap_block *new_vmap_block(gfp_t gfp_mask)
>
> vbq = &get_cpu_var(vmap_block_queue);
> spin_lock(&vbq->lock);
> - list_add_rcu(&vb->free_list, &vbq->free);
> + list_add_tail_rcu(&vb->free_list, &vbq->free);
> spin_unlock(&vbq->lock);
> put_cpu_var(vmap_block_queue);
>
I'm not sure about the cc:stable here. There is potential for
unexpected side-effects and I don't *think* people are hurting from
this issue in real life. Or maybe I'm wrong about that?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-03-24 22:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 14:04 [RFC v2 0/3] mm/vmalloc: fix possible exhaustion of vmalloc space Roman Pen
2015-03-19 14:04 ` [RFC v2 1/3] mm/vmalloc: fix possible exhaustion of vmalloc space caused by vm_map_ram allocator Roman Pen
2015-03-24 22:00 ` Andrew Morton [this message]
2015-03-25 6:07 ` Roman Peniaev
2015-03-25 1:01 ` Gioh Kim
2015-03-19 14:04 ` [RFC v2 2/3] mm/vmalloc: occupy newly allocated vmap block just after allocation Roman Pen
2015-03-19 14:04 ` [RFC v2 3/3] mm/vmalloc: get rid of dirty bitmap inside vmap_block structure Roman Pen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150324150054.a9050b7814860790e1d9b0d0@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=chaowang@redhat.com \
--cc=cl@linux.com \
--cc=edumazet@google.com \
--cc=fabf@skynet.be \
--cc=gioh.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=r.peniaev@gmail.com \
--cc=rientjes@google.com \
--cc=rob.jones@codethink.co.uk \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox