From: David Miller <davem@davemloft.net>
To: torvalds@linux-foundation.org
Cc: david.ahern@oracle.com, sparclinux@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
bpicco@meloft.net
Subject: Re: 4.0.0-rc4: panic in free_block
Date: Mon, 23 Mar 2015 15:08:33 -0400 (EDT) [thread overview]
Message-ID: <20150323.150833.1435862810481480096.davem@davemloft.net> (raw)
In-Reply-To: <CA+55aFzepCj56MPVgYmMem+yfYpSOX7tBRtPHeOQxXp31Tghhg@mail.gmail.com>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Mon, 23 Mar 2015 10:00:02 -0700
> Maybe the code could be something like
>
> void *memmove(void *dst, const void *src, size_t n);
> {
> // non-overlapping cases
> if (src + n <= dst)
> return memcpy(dst, src, n);
> if (dst + n <= src)
> return memcpy(dst, src, n);
>
> // overlapping, but we know we
> // (a) copy upwards
> // (b) initialize the result in at most chunks of 64
> if (dst+64 <= src)
> return memcpy(dst, src, n);
>
> .. do the backwards thing ..
> }
>
> (ok, maybe I got it wrong, but you get the idea).
>
> I *think* gcc should do ok on the above kind of code, and not generate
> wildly different code from your handcoded version.
Sure you could do that in C, but I really want to avoid using memcpy()
if dst and src overlap in any way at all.
Said another way, I don't want to codify that "64" thing. The next
chip could do 128 byte initializing stores.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-03-23 19:08 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 15:07 David Ahern
2015-03-20 16:48 ` Linus Torvalds
2015-03-20 16:53 ` David Ahern
2015-03-20 16:58 ` Linus Torvalds
2015-03-20 18:05 ` David Ahern
2015-03-20 18:53 ` Linus Torvalds
2015-03-20 19:04 ` David Ahern
2015-03-20 19:47 ` David Miller
2015-03-20 19:54 ` David Ahern
2015-03-20 20:19 ` David Miller
2015-03-20 19:42 ` David Miller
2015-03-20 20:01 ` Dave Hansen
2015-03-20 21:17 ` Linus Torvalds
2015-03-20 22:49 ` David Ahern
2015-03-21 0:18 ` David Ahern
2015-03-21 0:34 ` David Rientjes
2015-03-21 0:39 ` David Ahern
2015-03-21 0:47 ` Linus Torvalds
2015-03-21 17:45 ` David Ahern
2015-03-21 18:49 ` Linus Torvalds
2015-03-22 17:36 ` David Miller
2015-03-22 19:25 ` Bob Picco
2015-03-22 19:47 ` Linus Torvalds
2015-03-22 22:23 ` David Miller
2015-03-22 23:35 ` David Ahern
2015-03-22 23:54 ` David Miller
2015-03-23 0:03 ` David Ahern
2015-03-23 2:00 ` David Miller
2015-03-23 2:19 ` David Miller
2015-03-23 16:25 ` David Miller
2015-03-23 16:51 ` John Stoffel
2015-03-23 19:16 ` David Miller
2015-03-23 19:56 ` John Stoffel
2015-03-23 20:08 ` David Miller
2015-03-23 17:00 ` Linus Torvalds
2015-03-23 19:08 ` David Miller [this message]
2015-03-23 19:47 ` Linus Torvalds
2015-03-23 19:52 ` David Miller
2015-03-23 17:34 ` David Ahern
2015-03-23 19:35 ` David Miller
2015-03-23 19:58 ` David Ahern
2015-03-24 1:01 ` David Ahern
2015-03-24 14:57 ` Bob Picco
2015-03-24 16:05 ` David Miller
2015-03-22 23:49 ` Linus Torvalds
2015-03-22 23:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150323.150833.1435862810481480096.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bpicco@meloft.net \
--cc=david.ahern@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sparclinux@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox