From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) by kanga.kvack.org (Postfix) with ESMTP id D10E86B0038 for ; Wed, 18 Mar 2015 22:24:02 -0400 (EDT) Received: by pabxg6 with SMTP id xg6so47644634pab.0 for ; Wed, 18 Mar 2015 19:24:02 -0700 (PDT) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id kx15si39610214pab.228.2015.03.18.19.24.01 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Mar 2015 19:24:01 -0700 (PDT) Date: Wed, 18 Mar 2015 19:23:24 -0700 From: Andrew Morton Subject: Re: [PATCH V2 4/4] hugetlbfs: document min_size mount option Message-Id: <20150318192324.e0386907.akpm@linux-foundation.org> In-Reply-To: <550A2B9A.3060905@oracle.com> References: <3c82f2203e5453ddf3b29431863034afc7699303.1426549011.git.mike.kravetz@oracle.com> <20150318144108.e235862e0be30ff626e01820@linux-foundation.org> <550A2B9A.3060905@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Davidlohr Bueso , Aneesh Kumar , Joonsoo Kim On Wed, 18 Mar 2015 18:51:22 -0700 Mike Kravetz wrote: > > Nowhere here is the reader told the units of "size". We should at > > least describe that, and maybe even rename the thing to min_bytes. > > > > Ok, I will add that the size is in unit of bytes. My choice of > 'min_size' as a name for the new mount option was influenced by > the existing 'size' mount option. I'm open to any suggestions > for the name of this new mount option. Yes, due to the preexisting "size" I think we're stuck with "min_size". We could use min_size_bytes I guess, but the operator needs to go look up the units of "size" anyway. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org