From: Steven Rostedt <rostedt@goodmis.org>
To: Xie XiuQi <xiexiuqi@huawei.com>
Cc: Tony Luck <tony.luck@gmail.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Chen Gong <gong.chen@linux.intel.com>,
Bjorn Helgaas <bhelgaas@google.com>, Borislav Petkov <bp@suse.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
jingle.chen@huawei.com
Subject: Re: [PATCH] tracing: add trace event for memory-failure
Date: Tue, 17 Mar 2015 20:55:55 -0400 [thread overview]
Message-ID: <20150317205555.207b0605@grimm.local.home> (raw)
In-Reply-To: <5508064C.7090707@huawei.com>
On Tue, 17 Mar 2015 18:47:40 +0800
Xie XiuQi <xiexiuqi@huawei.com> wrote:
> I'm not clearly why we need a hard coded here. As the strings or "result" have
> defined in mm/memory-failure.c, so passing "action_name[result]" would be more
> clean and more flexible here?
The TP_printk() is what will be shown in the print format of the event
"format" file, and is what trace-cmd and perf use to parse the data and
know what to print. If you use "action_name[result]" that will be what
the user space tools see, and will have no idea what to do with
"action_name[result]". The hard coded output is a bit more explicit in
how to interpret the raw data.
Another way around this is to create a "plugin" that can be loaded and
will override the TP_printk() parsing.
-- Steve
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-03-18 0:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 10:10 Xie XiuQi
2015-03-13 16:37 ` Tony Luck
2015-03-13 19:32 ` Steven Rostedt
2015-03-17 10:47 ` Xie XiuQi
2015-03-18 0:55 ` Steven Rostedt [this message]
2015-03-16 9:27 ` Naoya Horiguchi
2015-03-16 13:04 ` Xie XiuQi
2015-03-19 3:04 Xie XiuQi
2015-03-19 3:22 ` Steven Rostedt
2015-03-19 10:39 ` Borislav Petkov
2015-03-20 4:15 ` Xie XiuQi
2015-03-20 17:24 ` Luck, Tony
2015-03-21 5:44 ` Xie XiuQi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150317205555.207b0605@grimm.local.home \
--to=rostedt@goodmis.org \
--cc=bhelgaas@google.com \
--cc=bp@suse.de \
--cc=gong.chen@linux.intel.com \
--cc=jingle.chen@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=tony.luck@gmail.com \
--cc=xiexiuqi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox