linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@suse.cz>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"akpm >> Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: mm: hangs in free_pages_prepare
Date: Sun, 8 Mar 2015 16:38:39 -0400	[thread overview]
Message-ID: <20150308203838.GA10442@dhcp22.suse.cz> (raw)
In-Reply-To: <54FB4590.20102@oracle.com>

On Sat 07-03-15 13:38:08, Sasha Levin wrote:
[...]
> [ 1573.730097] ? kasan_free_pages (mm/kasan/kasan.c:301)
> [ 1573.788680] free_pages_prepare (mm/page_alloc.c:791)
> [ 1573.788680] ? free_hot_cold_page (./arch/x86/include/asm/paravirt.h:809 (discriminator 2) mm/page_alloc.c:1579 (discriminator 2))
> [ 1573.788680] free_hot_cold_page (mm/page_alloc.c:1543)
> [ 1573.788680] __free_pages (mm/page_alloc.c:2957)
> [ 1573.788680] ? __vunmap (mm/vmalloc.c:1460 (discriminator 2))
> [ 1573.788680] __vunmap (mm/vmalloc.c:1460 (discriminator 2))

__vunmap is doing:
                for (i = 0; i < area->nr_pages; i++) {
                        struct page *page = area->pages[i];

                        BUG_ON(!page);
                        __free_page(page);
                }

is it possible that nr_pages is a huge number (a large vmalloc area)? I
do not see any cond_resched down __free_page path at least. vfree
delayes the call to workqueue when called from irq context and vunmap is
marked as might_sleep). So to me it looks like it would be safe. Something
for vmalloc familiar people, though.

Anyway, the loop seems to be there since ages so I guess somebody just
started calling vmalloc for huge areas recently so it shown up.
-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2015-03-08 20:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-07 18:38 Sasha Levin
2015-03-08 20:38 ` Michal Hocko [this message]
2015-03-08 20:49   ` Sasha Levin
2015-03-08 21:23     ` Michal Hocko
2015-03-17  8:58   ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150308203838.GA10442@dhcp22.suse.cz \
    --to=mhocko@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=sasha.levin@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox