[PATCH mmotm] x86, mm: ioremap_pud_capable can be static

[PATCH mmotm] x86, mm: ioremap_pud_capable can be static

[kbuild test robot]

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 ioremap.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/ioremap.c b/lib/ioremap.c
index 3055ada..1634c53 100644
--- a/lib/ioremap.c
+++ b/lib/ioremap.c
@@ -14,9 +14,9 @@
 #include <asm/pgtable.h>
 
 #ifdef CONFIG_HAVE_ARCH_HUGE_VMAP
-int __read_mostly ioremap_pud_capable;
-int __read_mostly ioremap_pmd_capable;
-int __read_mostly ioremap_huge_disabled;
+static int __read_mostly ioremap_pud_capable;
+static int __read_mostly ioremap_pmd_capable;
+static int __read_mostly ioremap_huge_disabled;
 
 static int __init set_nohugeiomap(char *str)
 {

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

[mmotm:master 126/298] lib/ioremap.c:17:19: sparse: symbol 'ioremap_pud_capable' was not declared. Should it be static?

[kbuild test robot]

tree:   git://git.cmpxchg.org/linux-mmotm.git master
head:   fe8eec967fb5db169b876720a6e0cced026173b6
commit: e4dc2631d6de08fe1ee5421944a71c7c89ed1d90 [126/298] x86, mm: support huge KVA mappings on x86
reproduce:
  # apt-get install sparse
  git checkout e4dc2631d6de08fe1ee5421944a71c7c89ed1d90
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> lib/ioremap.c:17:19: sparse: symbol 'ioremap_pud_capable' was not declared. Should it be static?
>> lib/ioremap.c:18:19: sparse: symbol 'ioremap_pmd_capable' was not declared. Should it be static?
>> lib/ioremap.c:19:19: sparse: symbol 'ioremap_huge_disabled' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH mmotm] x86, mm: ioremap_pud_capable can be static

[Toshi Kani]

On Thu, 2015-03-05 at 20:35 +0800, kbuild test robot wrote:
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Thanks for the update!

Reviewed-by: Toshi Kani <toshi.kani@hp.com>

-Toshi


> ---
>  ioremap.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/ioremap.c b/lib/ioremap.c
> index 3055ada..1634c53 100644
> --- a/lib/ioremap.c
> +++ b/lib/ioremap.c
> @@ -14,9 +14,9 @@
>  #include <asm/pgtable.h>
>  
>  #ifdef CONFIG_HAVE_ARCH_HUGE_VMAP
> -int __read_mostly ioremap_pud_capable;
> -int __read_mostly ioremap_pmd_capable;
> -int __read_mostly ioremap_huge_disabled;
> +static int __read_mostly ioremap_pud_capable;
> +static int __read_mostly ioremap_pmd_capable;
> +static int __read_mostly ioremap_huge_disabled;
>  
>  static int __init set_nohugeiomap(char *str)
>  {
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>