From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f172.google.com (mail-pd0-f172.google.com [209.85.192.172]) by kanga.kvack.org (Postfix) with ESMTP id 4B96A6B0038 for ; Wed, 4 Mar 2015 19:56:12 -0500 (EST) Received: by pdbft15 with SMTP id ft15so1343065pdb.6 for ; Wed, 04 Mar 2015 16:56:12 -0800 (PST) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id cw2si6984556pad.178.2015.03.04.16.56.11 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Mar 2015 16:56:11 -0800 (PST) Date: Wed, 4 Mar 2015 16:56:10 -0800 From: Andrew Morton Subject: Re: [PATCH v2 7/7] zsmalloc: add fullness into stat Message-Id: <20150304165610.5befcdbf2573c66509e77b55@linux-foundation.org> In-Reply-To: <20150305004330.GB2592@blaptop> References: <1425445292-29061-1-git-send-email-minchan@kernel.org> <1425445292-29061-8-git-send-email-minchan@kernel.org> <20150304140202.905f566b7107e2735d075b27@linux-foundation.org> <20150305004330.GB2592@blaptop> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Juneho Choi , Gunho Lee , Luigi Semenzato , Dan Streetman , Seth Jennings , Nitin Gupta , Jerome Marchand , Sergey Senozhatsky , Joonsoo Kim , opensource.ganesh@gmail.com On Thu, 5 Mar 2015 09:43:31 +0900 Minchan Kim wrote: > Hello Andrew, > > On Wed, Mar 04, 2015 at 02:02:02PM -0800, Andrew Morton wrote: > > On Wed, 4 Mar 2015 14:01:32 +0900 Minchan Kim wrote: > > > > > +static int zs_stats_size_show(struct seq_file *s, void *v) > > > +{ > > > + int i; > > > + struct zs_pool *pool = s->private; > > > + struct size_class *class; > > > + int objs_per_zspage; > > > + unsigned long class_almost_full, class_almost_empty; > > > + unsigned long obj_allocated, obj_used, pages_used; > > > + unsigned long total_class_almost_full = 0, total_class_almost_empty = 0; > > > + unsigned long total_objs = 0, total_used_objs = 0, total_pages = 0; > > > + > > > + seq_printf(s, " %5s %5s %11s %12s %13s %10s %10s %16s\n", > > > + "class", "size", "almost_full", "almost_empty", > > > + "obj_allocated", "obj_used", "pages_used", > > > + "pages_per_zspage"); > > > > Documentation? > > It should been since [0f050d9, mm/zsmalloc: add statistics support]. > Anyway, I will try it. > Where is right place to put only this statistics in Documentation? > > Documentation/zsmalloc.txt? > Documentation/vm/zsmalloc.txt? > Documentation/blockdev/zram.txt? > Documentation/ABI/testing/sysfs-block-zram? hm, this is debugfs so Documentation/ABI/testing/sysfs-block-zram isn't the right place. akpm3:/usr/src/25> grep -rli zsmalloc Documentation akpm3:/usr/src/25> lol. Documentation/vm/zsmalloc.txt looks good. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org