From: Andrew Morton <akpm@linux-foundation.org>
To: Jeff Vander Stoep <jeffv@google.com>
Cc: nnk@google.com, Sasha Levin <sasha.levin@oracle.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Rik van Riel <riel@redhat.com>, Vlastimil Babka <vbabka@suse.cz>,
Paul Cassella <cassella@cray.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: reorder can_do_mlock to fix audit denial
Date: Mon, 2 Mar 2015 16:42:28 -0800 [thread overview]
Message-ID: <20150302164228.4de418951c7d17b7e315d52f@linux-foundation.org> (raw)
In-Reply-To: <1425316867-6104-1-git-send-email-jeffv@google.com>
On Mon, 2 Mar 2015 09:20:32 -0800 Jeff Vander Stoep <jeffv@google.com> wrote:
> A userspace call to mmap(MAP_LOCKED) may result in the successful
> locking of memory while also producing a confusing audit log denial.
> can_do_mlock checks capable and rlimit. If either of these return
> positive can_do_mlock returns true. The capable check leads to an LSM
> hook used by apparmour and selinux which produce the audit denial.
> Reordering so rlimit is checked first eliminates the denial on success,
> only recording a denial when the lock is unsuccessful as a result of
> the denial.
I'm assuming that this is a minor issue - a bogus audit log, no other
consequences. And based on this I queued the patch for 4.0 with no
-stable backport.
All of this might have been wrong - the changelog wasn't very helpful
in making such decisions (hint).
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-03-03 0:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 17:20 Jeff Vander Stoep
2015-03-02 21:49 ` Nick Kralevich
2015-03-03 0:42 ` Andrew Morton [this message]
2015-03-03 0:49 ` Jeffrey Vander Stoep
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150302164228.4de418951c7d17b7e315d52f@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cassella@cray.com \
--cc=jeffv@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nnk@google.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=sasha.levin@oracle.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox