From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f173.google.com (mail-pd0-f173.google.com [209.85.192.173]) by kanga.kvack.org (Postfix) with ESMTP id 4E5CF6B0038 for ; Mon, 2 Mar 2015 15:04:10 -0500 (EST) Received: by pdjz10 with SMTP id z10so42029721pdj.12 for ; Mon, 02 Mar 2015 12:04:10 -0800 (PST) Received: from shards.monkeyblade.net (shards.monkeyblade.net. [2001:4f8:3:36:211:85ff:fe63:a549]) by mx.google.com with ESMTP id qz1si17712887pab.162.2015.03.02.12.04.09 for ; Mon, 02 Mar 2015 12:04:09 -0800 (PST) Date: Mon, 02 Mar 2015 15:04:05 -0500 (EST) Message-Id: <20150302.150405.2072800922470200977.davem@davemloft.net> Subject: Re: [RFC 3/4] sparc: remove __GFP_NOFAIL reuquirement From: David Miller In-Reply-To: <1425304483-7987-4-git-send-email-mhocko@suse.cz> References: <1425304483-7987-1-git-send-email-mhocko@suse.cz> <1425304483-7987-4-git-send-email-mhocko@suse.cz> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: mhocko@suse.cz Cc: linux-mm@kvack.org, akpm@linux-foundation.org, hannes@cmpxchg.org, rientjes@google.com, david@fromorbit.com, tytso@mit.edu, mgorman@suse.de, penguin-kernel@I-love.SAKURA.ne.jp, sparclinux@vger.kernel.org, vipul@chelsio.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Michal Hocko Date: Mon, 2 Mar 2015 14:54:42 +0100 > mdesc_kmalloc is currently requiring __GFP_NOFAIL allocation although it > seems that the allocation failure is handled by all callers (via > mdesc_alloc). __GFP_NOFAIL is a strong liability for the memory > allocator and so the users are discouraged to use the flag unless the > allocation failure is really a nogo. Drop the flag here as this doesn't > seem to be the case. > > Signed-off-by: Michal Hocko It is a serious failure. If we miss an MDESC update due to this allocation failure, the update is not an event which gets retransmitted so we will lose the updated machine description forever. We really need this allocation to succeed. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org