From: Michal Hocko <mhocko@suse.cz>
To: David Rientjes <rientjes@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
"\\\"Rafael J. Wysocki\\\"" <rjw@rjwysocki.net>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH -v2] mm, oom: do not fail __GFP_NOFAIL allocation if oom killer is disbaled
Date: Wed, 25 Feb 2015 15:08:26 +0100 [thread overview]
Message-ID: <20150225140826.GD26680@dhcp22.suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.10.1502241220500.3855@chino.kir.corp.google.com>
On Tue 24-02-15 12:23:55, David Rientjes wrote:
> On Tue, 24 Feb 2015, Johannes Weiner wrote:
[...]
> > I'm fine with keeping the allocation looping, but is that message
> > helpful? It seems completely useless to the user encountering it. Is
> > it going to help kernel developers when we get a bug report with it?
> >
> > WARN_ON_ONCE()?
> >
>
> Yeah, I'm not sure that the warning is helpful (and it needs
> s/disbaled/disabled/ if it is to be kept). I also think this check should
> be moved out of out_of_memory() since gfp/retry logic should be in the
> page allocator itself and not in the oom killer: just make
> __alloc_pages_may_oom() also set *did_some_progress = 1 for __GFP_NOFAIL.
OK, this is a good point. Updated patch is below:
---
next prev parent reply other threads:[~2015-02-25 14:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 18:19 [PATCH] " Michal Hocko
2015-02-24 18:22 ` Michal Hocko
2015-02-24 19:11 ` Johannes Weiner
2015-02-24 20:23 ` David Rientjes
2015-02-25 14:08 ` Michal Hocko [this message]
2015-02-25 20:41 ` [PATCH -v2] " David Rientjes
2015-02-26 17:34 ` Michal Hocko
2015-02-24 22:09 ` [PATCH] " Konstantin Khlebnikov
2015-02-24 22:16 ` Konstantin Khlebnikov
2015-02-25 14:02 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150225140826.GD26680@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=rientjes@google.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox