linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@cmpxchg.org>
To: Shachar Raindel <raindel@mellanox.com>
Cc: linux-mm@kvack.org, kirill.shutemov@linux.intel.com,
	mgorman@suse.de, riel@redhat.com, ak@linux.intel.com,
	matthew.r.wilcox@intel.com, dave.hansen@linux.intel.com,
	n-horiguchi@ah.jp.nec.com, akpm@linux-foundation.org,
	torvalds@linux-foundation.org, haggaie@mellanox.com,
	aarcange@redhat.com, pfeiner@google.com, sagig@mellanox.com,
	walken@google.com, Dave Hansen <dave.hansen@intel.com>
Subject: Re: [PATCH V4 4/4] mm: Refactor do_wp_page handling of shared vma into a function
Date: Sun, 22 Feb 2015 08:28:32 -0500	[thread overview]
Message-ID: <20150222132832.GD5324@phnom.home.cmpxchg.org> (raw)
In-Reply-To: <1424609241-20106-5-git-send-email-raindel@mellanox.com>

On Sun, Feb 22, 2015 at 02:47:21PM +0200, Shachar Raindel wrote:
> The do_wp_page function is extremely long. Extract the logic for
> handling a page belonging to a shared vma into a function of its own.
> 
> This helps the readability of the code, without doing any functional
> change in it.
> 
> Signed-off-by: Shachar Raindel <raindel@mellanox.com>
> Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Acked-by: Rik van Riel <riel@redhat.com>
> Acked-by: Andi Kleen <ak@linux.intel.com>
> Acked-by: Haggai Eran <haggaie@mellanox.com>
> Cc: Mel Gorman <mgorman@suse.de>
> Cc: Matthew Wilcox <matthew.r.wilcox@intel.com>
> Cc: Dave Hansen <dave.hansen@intel.com>
> Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Andrea Arcangeli <aarcange@redhat.com>
> Cc: Peter Feiner <pfeiner@google.com>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Michel Lespinasse <walken@google.com>

Acked-by: Johannes Weiner <hannes@cmpxchg.org>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2015-02-22 13:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-22 12:47 [PATCH V4 0/4] Refactor do_wp_page, no functional change Shachar Raindel
2015-02-22 12:47 ` [PATCH V4 1/4] mm: Refactor do_wp_page, extract the reuse case Shachar Raindel
2015-02-22 13:09   ` Johannes Weiner
2015-02-22 12:47 ` [PATCH V4 2/4] mm: Refactor do_wp_page - rewrite the unlock flow Shachar Raindel
2015-02-22 13:19   ` Johannes Weiner
2015-02-22 12:47 ` [PATCH V4 3/4] mm: refactor do_wp_page, extract the page copy flow Shachar Raindel
2015-02-22 13:24   ` Johannes Weiner
2015-02-22 12:47 ` [PATCH V4 4/4] mm: Refactor do_wp_page handling of shared vma into a function Shachar Raindel
2015-02-22 13:28   ` Johannes Weiner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150222132832.GD5324@phnom.home.cmpxchg.org \
    --to=hannes@cmpxchg.org \
    --cc=aarcange@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave.hansen@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=haggaie@mellanox.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-mm@kvack.org \
    --cc=matthew.r.wilcox@intel.com \
    --cc=mgorman@suse.de \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=pfeiner@google.com \
    --cc=raindel@mellanox.com \
    --cc=riel@redhat.com \
    --cc=sagig@mellanox.com \
    --cc=torvalds@linux-foundation.org \
    --cc=walken@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox