[aa:userfault 17/19] mm/userfaultfd.c:48:6: sparse: symbol 'double_down_read' was not declared. Should it be static?

[aa:userfault 17/19] mm/userfaultfd.c:48:6: sparse: symbol 'double_down_read' was not declared. Should it be static?

[kbuild test robot]

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/andrea/aa.git userfault
head:   9866337e3999d167b77303ad9e57fd20919893e3
commit: e2ccdb8c9f49438f9c8910f2f93c7e5ee35d8644 [17/19] userfaultfd: add new syscall to provide memory externalization
reproduce:
  # apt-get install sparse
  git checkout e2ccdb8c9f49438f9c8910f2f93c7e5ee35d8644
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> mm/userfaultfd.c:48:6: sparse: symbol 'double_down_read' was not declared. Should it be static?
>> mm/userfaultfd.c:67:6: sparse: symbol 'double_up_read' was not declared. Should it be static?
>> mm/userfaultfd.c:34:9: sparse: context imbalance in 'double_pt_lock' - different lock contexts for basic block
>> mm/userfaultfd.c:44:9: sparse: context imbalance in 'double_pt_unlock' - different lock contexts for basic block
>> mm/userfaultfd.c:63:9: sparse: context imbalance in 'double_down_read' - wrong count at exit
>> mm/userfaultfd.c:73:9: sparse: context imbalance in 'double_up_read' - wrong count at exit
>> mm/userfaultfd.c:551:9: sparse: context imbalance in 'remap_anon_pages' - different lock contexts for basic block

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

[PATCH aa] userfaultfd: double_down_read() can be static

[kbuild test robot]

mm/userfaultfd.c:48:6: sparse: symbol 'double_down_read' was not declared. Should it be static?
mm/userfaultfd.c:67:6: sparse: symbol 'double_up_read' was not declared. Should it be static?

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 userfaultfd.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c
index d1e89ef..88b2650 100644
--- a/mm/userfaultfd.c
+++ b/mm/userfaultfd.c
@@ -45,7 +45,7 @@ void double_pt_unlock(spinlock_t *ptl1,
 		spin_unlock(ptl2);
 }
 
-void double_down_read(struct rw_semaphore *mm1,
+static void double_down_read(struct rw_semaphore *mm1,
 		      struct rw_semaphore *mm2)
 	__acquires(mm1)
 	__acquires(mm2)
@@ -64,7 +64,7 @@ void double_down_read(struct rw_semaphore *mm1,
 		down_read_nested(mm2, SINGLE_DEPTH_NESTING);
 }
 
-void double_up_read(struct rw_semaphore *mm1,
+static void double_up_read(struct rw_semaphore *mm1,
 		    struct rw_semaphore *mm2)
 	__releases(mm1)
 	__releases(mm2)

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>