From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yk0-f171.google.com (mail-yk0-f171.google.com [209.85.160.171]) by kanga.kvack.org (Postfix) with ESMTP id 22E7D6B0032 for ; Wed, 11 Feb 2015 17:38:10 -0500 (EST) Received: by mail-yk0-f171.google.com with SMTP id q200so253503ykb.2 for ; Wed, 11 Feb 2015 14:38:10 -0800 (PST) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id r9si2704740qcg.13.2015.02.11.14.38.08 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Feb 2015 14:38:09 -0800 (PST) Date: Wed, 11 Feb 2015 23:33:09 +0100 From: Andrea Arcangeli Subject: Re: [PATCH v2] mm: incorporate zero pages into transparent huge pages Message-ID: <20150211223309.GO11755@redhat.com> References: <1423688635-4306-1-git-send-email-ebru.akagunduz@gmail.com> <20150211221600.GN11755@redhat.com> <20150211222140.GA12928@node.dhcp.inet.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150211222140.GA12928@node.dhcp.inet.fi> Sender: owner-linux-mm@kvack.org List-ID: To: "Kirill A. Shutemov" Cc: Ebru Akagunduz , linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@suse.cz, mgorman@suse.de, rientjes@google.com, sasha.levin@oracle.com, hughd@google.com, hannes@cmpxchg.org, vbabka@suse.cz, linux-kernel@vger.kernel.org, riel@redhat.com On Thu, Feb 12, 2015 at 12:21:40AM +0200, Kirill A. Shutemov wrote: > On Wed, Feb 11, 2015 at 11:16:00PM +0100, Andrea Arcangeli wrote: > > On Wed, Feb 11, 2015 at 11:03:55PM +0200, Ebru Akagunduz wrote: > > > Changes in v2: > > > - Check zero pfn in release_pte_pages() (Andrea Arcangeli) > > > > .. and in: > > > > > @@ -2237,7 +2237,7 @@ static void __collapse_huge_page_copy(pte_t *pte, struct page *page, > > > pte_t pteval = *_pte; > > > struct page *src_page; > > > > > > - if (pte_none(pteval)) { > > > + if (pte_none(pteval) || is_zero_pfn(pte_pfn(pteval))) { > > > clear_user_highpage(page, address); > > > add_mm_counter(vma->vm_mm, MM_ANONPAGES, 1); > > > } else { > > > > __collapse_huge_page_copy, both were needed as far as I can tell. > > There was is_zero_pfn(pte_pfn(pteval)) in __collapse_huge_page_copy() in > original patch. That clarifies things ok. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org