From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by kanga.kvack.org (Postfix) with ESMTP id F02036B0032 for ; Wed, 11 Feb 2015 17:21:50 -0500 (EST) Received: by mail-wi0-f173.google.com with SMTP id bs8so23987336wib.0 for ; Wed, 11 Feb 2015 14:21:50 -0800 (PST) Received: from kirsi1.inet.fi (mta-out1.inet.fi. [62.71.2.227]) by mx.google.com with ESMTP id ea7si20858671wib.6.2015.02.11.14.21.48 for ; Wed, 11 Feb 2015 14:21:49 -0800 (PST) Date: Thu, 12 Feb 2015 00:21:40 +0200 From: "Kirill A. Shutemov" Subject: Re: [PATCH v2] mm: incorporate zero pages into transparent huge pages Message-ID: <20150211222140.GA12928@node.dhcp.inet.fi> References: <1423688635-4306-1-git-send-email-ebru.akagunduz@gmail.com> <20150211221600.GN11755@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150211221600.GN11755@redhat.com> Sender: owner-linux-mm@kvack.org List-ID: To: Andrea Arcangeli Cc: Ebru Akagunduz , linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@suse.cz, mgorman@suse.de, rientjes@google.com, sasha.levin@oracle.com, hughd@google.com, hannes@cmpxchg.org, vbabka@suse.cz, linux-kernel@vger.kernel.org, riel@redhat.com On Wed, Feb 11, 2015 at 11:16:00PM +0100, Andrea Arcangeli wrote: > On Wed, Feb 11, 2015 at 11:03:55PM +0200, Ebru Akagunduz wrote: > > Changes in v2: > > - Check zero pfn in release_pte_pages() (Andrea Arcangeli) > > .. and in: > > > @@ -2237,7 +2237,7 @@ static void __collapse_huge_page_copy(pte_t *pte, struct page *page, > > pte_t pteval = *_pte; > > struct page *src_page; > > > > - if (pte_none(pteval)) { > > + if (pte_none(pteval) || is_zero_pfn(pte_pfn(pteval))) { > > clear_user_highpage(page, address); > > add_mm_counter(vma->vm_mm, MM_ANONPAGES, 1); > > } else { > > __collapse_huge_page_copy, both were needed as far as I can tell. There was is_zero_pfn(pte_pfn(pteval)) in __collapse_huge_page_copy() in original patch. > I haven't tested it but it's looking good. > > Reviewed-by: Andrea Arcangeli Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org