From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] Introduce <linux/mm_struct.h>
Date: Wed, 28 Jan 2015 22:45:44 +0200 [thread overview]
Message-ID: <20150128204544.GA15649@node.dhcp.inet.fi> (raw)
In-Reply-To: <20150128185052.GA6118@roeck-us.net>
On Wed, Jan 28, 2015 at 10:50:52AM -0800, Guenter Roeck wrote:
> On Wed, Jan 28, 2015 at 03:17:40PM +0200, Kirill A. Shutemov wrote:
> > This patchset moves definition of mm_struct into separate header file.
> > It allows to get rid of nr_pmds if PMD page table level is folded.
> > We cannot do it with current mm_types.h because we need
> > __PAGETABLE_PMD_FOLDED from <asm/pgtable.h> which creates circular
> > dependencies.
> >
> > I've done few build tests and looks like it works, but I expect breakage
> > on some configuration. Please test.
> >
> Doesn't look good.
>
> Build results:
> total: 134 pass: 63 fail: 71
> Failed builds:
> arm:s3c2410_defconfig
> arm:omap2plus_defconfig
> arm:imx_v6_v7_defconfig
> arm:ixp4xx_defconfig
> arm:u8500_defconfig
> arm:multi_v5_defconfig
> arm:multi_v7_defconfig
> arm:omap1_defconfig
> arm:footbridge_defconfig
> arm:davinci_all_defconfig
> arm:mini2440_defconfig
> arm:rpc_defconfig
> arm:axm55xx_defconfig
> arm:mxs_defconfig
> arm:keystone_defconfig
> arm:vexpress_defconfig
> arm:imx_v4_v5_defconfig
> arm:at91_dt_defconfig
> arm:s3c6400_defconfig
> arm:lpc32xx_defconfig
> arm:shmobile_defconfig
> arm:nhk8815_defconfig
> arm:bcm2835_defconfig
> arm:sama5_defconfig
> arm:orion5x_defconfig
> arm:exynos_defconfig
> arm:cm_x2xx_defconfig
> arm:s5pv210_defconfig
> arm:integrator_defconfig
> arm:msm_defconfig
> arm:pxa910_defconfig
> arm:clps711x_defconfig
Could you try this for arm?
diff --git a/arch/arm/include/asm/pgtable.h b/arch/arm/include/asm/pgtable.h
index f40354198bad..bb4ae035e5e3 100644
--- a/arch/arm/include/asm/pgtable.h
+++ b/arch/arm/include/asm/pgtable.h
@@ -24,9 +24,6 @@
#include <asm/memory.h>
#include <asm/pgtable-hwdef.h>
-
-#include <asm/tlbflush.h>
-
#ifdef CONFIG_ARM_LPAE
#include <asm/pgtable-3level.h>
#else
diff --git a/arch/arm/mm/mm.h b/arch/arm/mm/mm.h
index ce727d47275c..b5e764e0d5a8 100644
--- a/arch/arm/mm/mm.h
+++ b/arch/arm/mm/mm.h
@@ -3,6 +3,7 @@
#include <linux/vmalloc.h>
#include <asm/pgtable.h>
+#include <asm/tlbflush.h>
/* the upper-most page table pointer */
extern pmd_t *top_pmd;
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-01-28 20:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 13:17 Kirill A. Shutemov
2015-01-28 13:17 ` [PATCH 1/4] mm: move enum tlb_flush_reason into <trace/events/tlb.h> Kirill A. Shutemov
2015-01-28 13:17 ` [PATCH 2/4] mm: split up mm_struct to separate header file Kirill A. Shutemov
2015-01-29 0:30 ` Kirill A. Shutemov
2015-01-29 2:02 ` Guenter Roeck
2015-01-29 4:22 ` Guenter Roeck
2015-01-28 13:17 ` [PATCH 3/4] mm: define __PAGETABLE_{PMD,PUD}_FOLDED to zero or one Kirill A. Shutemov
2015-01-28 13:17 ` [PATCH 4/4] mm: do not add nr_pmds into mm_struct if PMD is folded Kirill A. Shutemov
2015-01-28 17:06 ` [PATCH 0/4] Introduce <linux/mm_struct.h> Guenter Roeck
2015-01-28 18:50 ` Guenter Roeck
2015-01-28 20:45 ` Kirill A. Shutemov [this message]
2015-01-28 21:18 ` Guenter Roeck
2015-01-28 21:16 ` Kirill A. Shutemov
2015-01-28 21:19 Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150128204544.GA15649@node.dhcp.inet.fi \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox