From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f174.google.com (mail-pd0-f174.google.com [209.85.192.174]) by kanga.kvack.org (Postfix) with ESMTP id 069C76B0032 for ; Wed, 28 Jan 2015 00:35:50 -0500 (EST) Received: by mail-pd0-f174.google.com with SMTP id ft15so23508905pdb.5 for ; Tue, 27 Jan 2015 21:35:49 -0800 (PST) Received: from mail-pd0-x230.google.com (mail-pd0-x230.google.com. [2607:f8b0:400e:c02::230]) by mx.google.com with ESMTPS id v13si4267781pdi.194.2015.01.27.21.35.48 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 27 Jan 2015 21:35:49 -0800 (PST) Received: by mail-pd0-f176.google.com with SMTP id y10so23494151pdj.7 for ; Tue, 27 Jan 2015 21:35:48 -0800 (PST) Date: Wed, 28 Jan 2015 14:35:42 +0900 From: Minchan Kim Subject: Re: [PATCH 1/2] zram: free meta out of init_lock Message-ID: <20150128053541.GE32712@blaptop> References: <20150127031823.GA16797@blaptop> <20150127040305.GB665@swordfish> <20150128001526.GA25828@blaptop> <20150128002203.GB25828@blaptop> <20150128020759.GA343@swordfish> <20150128025707.GB32712@blaptop> <20150128035354.GA7790@swordfish> <20150128040757.GA577@swordfish> <20150128045028.GB577@swordfish> <20150128045855.GD32712@blaptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150128045855.GD32712@blaptop> Sender: owner-linux-mm@kvack.org List-ID: To: Sergey Senozhatsky Cc: Sergey Senozhatsky , Jerome Marchand , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Nitin Gupta On Wed, Jan 28, 2015 at 01:58:55PM +0900, Minchan Kim wrote: > On Wed, Jan 28, 2015 at 01:50:28PM +0900, Sergey Senozhatsky wrote: > > On (01/28/15 13:07), Sergey Senozhatsky wrote: > > > On (01/28/15 12:53), Sergey Senozhatsky wrote: > > > > > So, I want to go with srcu. Do you agree? or another suggestion? > > > > > > > > yes, I think we need to take a second look on srcu approach. > > > > > > > > > > ... or we can ask lockdep to stop false alarming us and leave it as is. > > > I wouldn't say that ->init_lock is so hard to understand. > > > just as an option. > > > > > > > so... returning back to barriers performance implications. > > > > x86_64, lzo, 4 comp streams, 2G zram, ext4, mount -o rw,relatime,data=ordered > > > > ./iozone -t 3 -R -r 16K -s 60M -I +Z > > > > test base srcu > > " Initial write " 1299639.75 1277621.03 > > " Rewrite " 2139387.50 2004663.94 > > " Read " 6193415.00 5091000.00 > > " Re-read " 6199050.38 4814297.88 > > " Reverse Read " 4693868.88 4367201.75 > > " Stride read " 4470633.75 4247550.00 > > " Random read " 5115339.50 4517352.75 > > " Mixed workload " 4340747.06 3880517.31 > > " Random write " 1982369.75 1892456.25 > > " Pwrite " 1352550.22 1248667.78 > > " Pread " 2853150.06 2445154.41 > > " Fwrite " 2367397.81 2262384.56 > > " Fread " 8100746.50 7578071.75 > > > > not good. > > > > Oops, I never thought it could make mesurable performance. > I will investigate it. > > Thanks a lot, Sergey! Sergey, the data is consistent for repeated work? I tested it with dd on /dev/zram0 without any FS on my KVM and I cannot see any measureable performance gap. Hmm, I will try it on real machine. -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org