From: Andrew Morton <akpm@linux-foundation.org>
To: Toshi Kani <toshi.kani@hp.com>
Cc: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com,
arnd@arndb.de, linux-mm@kvack.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 3/7] mm: Change ioremap to set up huge I/O mappings
Date: Mon, 26 Jan 2015 15:58:11 -0800 [thread overview]
Message-ID: <20150126155811.0ade183f5f3f89277d11fde6@linux-foundation.org> (raw)
In-Reply-To: <1422314009-31667-4-git-send-email-toshi.kani@hp.com>
On Mon, 26 Jan 2015 16:13:25 -0700 Toshi Kani <toshi.kani@hp.com> wrote:
> Change ioremap_pud_range() and ioremap_pmd_range() to set up
> huge I/O mappings when their capability is enabled and their
> conditions are met in a given request -- both virtual & physical
> addresses are aligned and its range fufills the mapping size.
>
> These changes are only enabled when both CONFIG_HUGE_IOMAP
> and CONFIG_HAVE_ARCH_HUGE_VMAP are defined.
>
> --- a/lib/ioremap.c
> +++ b/lib/ioremap.c
> @@ -81,6 +81,14 @@ static inline int ioremap_pmd_range(pud_t *pud, unsigned long addr,
> return -ENOMEM;
> do {
> next = pmd_addr_end(addr, end);
> +
> + if (ioremap_pmd_enabled() &&
> + ((next - addr) == PMD_SIZE) &&
> + !((phys_addr + addr) & (PMD_SIZE-1))) {
IS_ALIGNED might be a little neater here.
> + pmd_set_huge(pmd, phys_addr + addr, prot);
> + continue;
> + }
> +
> if (ioremap_pte_range(pmd, addr, next, phys_addr + addr, prot))
> return -ENOMEM;
> } while (pmd++, addr = next, addr != end);
> @@ -99,6 +107,14 @@ static inline int ioremap_pud_range(pgd_t *pgd, unsigned long addr,
> return -ENOMEM;
> do {
> next = pud_addr_end(addr, end);
> +
> + if (ioremap_pud_enabled() &&
> + ((next - addr) == PUD_SIZE) &&
> + !((phys_addr + addr) & (PUD_SIZE-1))) {
And here.
> + pud_set_huge(pud, phys_addr + addr, prot);
> + continue;
> + }
> +
> if (ioremap_pmd_range(pud, addr, next, phys_addr + addr, prot))
> return -ENOMEM;
> } while (pud++, addr = next, addr != end);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-01-26 23:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 23:13 [RFC PATCH 0/7] Kernel huge I/O mapping support Toshi Kani
2015-01-26 23:13 ` [RFC PATCH 1/7] mm: Change __get_vm_area_node() to use fls_long() Toshi Kani
2015-01-26 23:13 ` [RFC PATCH 2/7] lib: Add huge I/O map capability interfaces Toshi Kani
2015-01-26 23:54 ` Andrew Morton
2015-01-27 1:01 ` Toshi Kani
2015-01-27 21:37 ` Andrew Morton
2015-01-27 22:01 ` Toshi Kani
2015-02-05 20:56 ` Toshi Kani
2015-01-26 23:13 ` [RFC PATCH 3/7] mm: Change ioremap to set up huge I/O mappings Toshi Kani
2015-01-26 23:58 ` Andrew Morton [this message]
2015-01-27 0:01 ` Toshi Kani
2015-01-26 23:13 ` [RFC PATCH 4/7] mm: Change vunmap to tear down huge KVA mappings Toshi Kani
2015-01-26 23:13 ` [RFC PATCH 5/7] x86, mm: Support huge KVA mappings on x86 Toshi Kani
2015-01-26 23:13 ` [RFC PATCH 6/7] x86, mm: Support huge I/O " Toshi Kani
2015-01-26 23:13 ` [RFC PATCH 7/7] mm: Add config HUGE_IOMAP to enable huge I/O mappings Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150126155811.0ade183f5f3f89277d11fde6@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=toshi.kani@hp.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox