From: Johannes Weiner <hannes@cmpxchg.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Michal Hocko <mhocko@suse.cz>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] mm: memcontrol: uninitialized "ret" variables
Date: Thu, 22 Jan 2015 10:25:35 -0500 [thread overview]
Message-ID: <20150122152535.GB27368@phnom.home.cmpxchg.org> (raw)
In-Reply-To: <20150122133044.GA23668@mwanda>
Hi Dan,
On Thu, Jan 22, 2015 at 04:30:44PM +0300, Dan Carpenter wrote:
> We recently re-arranged the code in these functions and now static
> checkers complain that "ret" is uninitialized. Oddly enough GCC is fine
> with this code.
>
> Fixes: d1ebc463cf89 ('mm: page_counter: pull "-1" handling out of page_counter_memparse()')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
This code was again re-arranged in -mm, and that
ret = page_counter_memparse()
is now happening unconditionally, so I think it should be fine. The
latest mmots snapshot (mmots-2015-01-21-16-38) has it.
Thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2015-01-22 15:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 13:30 Dan Carpenter
2015-01-22 15:25 ` Johannes Weiner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150122152535.GB27368@phnom.home.cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=cgroups@vger.kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox