From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f45.google.com (mail-pa0-f45.google.com [209.85.220.45]) by kanga.kvack.org (Postfix) with ESMTP id AA7BE6B0032 for ; Thu, 22 Jan 2015 15:47:11 -0500 (EST) Received: by mail-pa0-f45.google.com with SMTP id lf10so4138535pab.4 for ; Thu, 22 Jan 2015 12:47:11 -0800 (PST) Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bon0116.outbound.protection.outlook.com. [157.56.111.116]) by mx.google.com with ESMTPS id y5si13768084pas.146.2015.01.22.12.47.10 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 22 Jan 2015 12:47:10 -0800 (PST) Date: Thu, 22 Jan 2015 14:41:47 -0600 From: Kim Phillips Subject: Re: [PATCH 2/2] mm: fix undefined reference to `.kernel_map_pages' on PPC builds Message-ID: <20150122144147.019eedc41f189eac44c3c4cd@freescale.com> In-Reply-To: <20150122014550.GA21444@js1304-P5Q-DELUXE> References: <20150120140200.aa7ba0eb28d95e456972e178@freescale.com> <20150120230150.GA14475@cloud> <20150120160738.edfe64806cc8b943beb1dfa0@linux-foundation.org> <20150122014550.GA21444@js1304-P5Q-DELUXE> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Joonsoo Kim Cc: Akinobu Mita , Andrew Morton , josh@joshtriplett.org, Johannes Weiner , Minchan Kim , Rik van Riel , Sasha Levin , Al Viro , Konstantin Khlebnikov , Jens Axboe , linux-mm@kvack.org, LKML , linuxppc-dev On Thu, 22 Jan 2015 10:45:51 +0900 Joonsoo Kim wrote: > On Wed, Jan 21, 2015 at 09:57:59PM +0900, Akinobu Mita wrote: > > 2015-01-21 9:07 GMT+09:00 Andrew Morton : > > > On Tue, 20 Jan 2015 15:01:50 -0800 josh@joshtriplett.org wrote: > > > > > >> On Tue, Jan 20, 2015 at 02:02:00PM -0600, Kim Phillips wrote: > > >> > It's possible to configure DEBUG_PAGEALLOC without PAGE_POISONING on > > >> > ppc. Fix building the generic kernel_map_pages() implementation in > > >> > this case: > > >> > > > >> > LD init/built-in.o > > >> > mm/built-in.o: In function `free_pages_prepare': > > >> > mm/page_alloc.c:770: undefined reference to `.kernel_map_pages' > > >> > mm/built-in.o: In function `prep_new_page': > > >> > mm/page_alloc.c:933: undefined reference to `.kernel_map_pages' > > >> > mm/built-in.o: In function `map_pages': > > >> > mm/compaction.c:61: undefined reference to `.kernel_map_pages' > > >> > make: *** [vmlinux] Error 1 > > > > kernel_map_pages() is static inline function since commit 031bc5743f15 > > ("mm/debug-pagealloc: make debug-pagealloc boottime configurable"). > > > > But there is old declaration in 'arch/powerpc/include/asm/cacheflush.h'. > > Removing it or changing s/kernel_map_pages/__kernel_map_pages/ in this > > header file or something can fix this problem? > > > > The architecture which has ARCH_SUPPORTS_DEBUG_PAGEALLOC > > including PPC should not build mm/debug-pagealloc.o > > Yes, architecture with ARCH_SUPPORTS_DEBUG_PAGEALLOC should not build > mm/debug-pagealloc.o. I attach the patch to remove old declaration. > I hope it will fix Kim's problem. > > -------------->8------------------ > From 7cb9d1ed8a785df152cb8934e187031c8ebd1bb2 Mon Sep 17 00:00:00 2001 > From: Joonsoo Kim > Date: Thu, 22 Jan 2015 10:28:58 +0900 > Subject: [PATCH] mm/debug_pagealloc: fix build failure on ppc and some other > archs > > Kim Phillips reported following build failure. > > LD init/built-in.o > mm/built-in.o: In function `free_pages_prepare': > mm/page_alloc.c:770: undefined reference to `.kernel_map_pages' > mm/built-in.o: In function `prep_new_page': > mm/page_alloc.c:933: undefined reference to `.kernel_map_pages' > mm/built-in.o: In function `map_pages': > mm/compaction.c:61: undefined reference to `.kernel_map_pages' > make: *** [vmlinux] Error 1 > > Reason for this problem is that commit 031bc5743f15 > ("mm/debug-pagealloc: make debug-pagealloc boottime configurable") forgot > to remove old declaration of kernel_map_pages() in some architectures. > This patch removes them to fix build failure. > > Reported-by: Kim Phillips > Signed-off-by: Joonsoo Kim > --- Thanks. Now I get this: LD init/built-in.o mm/built-in.o: In function `kernel_map_pages': include/linux/mm.h:2076: undefined reference to `.__kernel_map_pages' include/linux/mm.h:2076: undefined reference to `.__kernel_map_pages' include/linux/mm.h:2076: undefined reference to `.__kernel_map_pages' Makefile:925: recipe for target 'vmlinux' failed make: *** [vmlinux] Error 1 but, AFAICT, that's not because this patch is invalid: it's because __kernel_map_pages() isn't implemented in arch/powerpc/mm/pgtable_64.c, i.e., for non-PPC_STD_MMU_64 PPC64 machines. Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org