From: Brian Norris <computersforpeace@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@fb.com>,
linux-nfs@vger.kernel.org, linux-mm@kvack.org,
David Howells <dhowells@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org,
Tejun Heo <tj@kernel.org>,
ceph-devel@vger.kernel.org, David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 03/12] fs: introduce f_op->mmap_capabilities for nommu mmap support
Date: Thu, 15 Jan 2015 20:06:28 -0800 [thread overview]
Message-ID: <20150116040628.GG9759@ld-irv-0074> (raw)
In-Reply-To: <1421228561-16857-4-git-send-email-hch@lst.de>
+ dwmw2
On Wed, Jan 14, 2015 at 10:42:32AM +0100, Christoph Hellwig wrote:
> Since "BDI: Provide backing device capability information [try #3]" the
> backing_dev_info structure also provides flags for the kind of mmap
> operation available in a nommu environment, which is entirely unrelated
> to it's original purpose.
>
> Introduce a new nommu-only file operation to provide this information to
> the nommu mmap code instead. Splitting this from the backing_dev_info
> structure allows to remove lots of backing_dev_info instance that aren't
> otherwise needed, and entirely gets rid of the concept of providing a
> backing_dev_info for a character device. It also removes the need for
> the mtd_inodefs filesystem.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Tejun Heo <tj@kernel.org>
> ---
> Documentation/nommu-mmap.txt | 8 +--
> block/blk-core.c | 2 +-
> drivers/char/mem.c | 64 ++++++++++----------
> drivers/mtd/mtdchar.c | 72 ++++------------------
> drivers/mtd/mtdconcat.c | 10 ----
> drivers/mtd/mtdcore.c | 80 +++++++------------------
> drivers/mtd/mtdpart.c | 1 -
There's a small conflict in mtdcore.c with some stuff I have queued up
for MTD in linux-next. Should be trivial to resolve later.
I don't have a test platform for nommu, and I'll admit I'm not too
familiar with this code, but it looks OK to me. So FWIW, for the MTD
parts:
Acked-by: Brian Norris <computersforpeace@gmail.com>
> drivers/staging/lustre/lustre/llite/llite_lib.c | 2 +-
> fs/9p/v9fs.c | 2 +-
> fs/afs/volume.c | 2 +-
> fs/aio.c | 14 +----
> fs/btrfs/disk-io.c | 3 +-
> fs/char_dev.c | 24 --------
> fs/cifs/connect.c | 2 +-
> fs/coda/inode.c | 2 +-
> fs/configfs/configfs_internal.h | 2 -
> fs/configfs/inode.c | 18 +-----
> fs/configfs/mount.c | 11 +---
> fs/ecryptfs/main.c | 2 +-
> fs/exofs/super.c | 2 +-
> fs/ncpfs/inode.c | 2 +-
> fs/ramfs/file-nommu.c | 7 +++
> fs/ramfs/inode.c | 22 +------
> fs/romfs/mmap-nommu.c | 10 ++++
> fs/ubifs/super.c | 2 +-
> include/linux/backing-dev.h | 33 ++--------
> include/linux/cdev.h | 2 -
> include/linux/fs.h | 23 +++++++
> include/linux/mtd/mtd.h | 2 +
> mm/backing-dev.c | 7 +--
> mm/nommu.c | 69 ++++++++++-----------
> security/security.c | 13 ++--
> 32 files changed, 169 insertions(+), 346 deletions(-)
[...]
Brian
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-01-16 4:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 9:42 backing_dev_info cleanups & lifetime rule fixes V2 Christoph Hellwig
2015-01-14 9:42 ` [PATCH 01/12] fs: deduplicate noop_backing_dev_info Christoph Hellwig
2015-01-14 12:41 ` Jan Kara
2015-01-14 9:42 ` [PATCH 02/12] fs: kill BDI_CAP_SWAP_BACKED Christoph Hellwig
2015-01-14 12:47 ` Jan Kara
2015-01-14 9:42 ` [PATCH 03/12] fs: introduce f_op->mmap_capabilities for nommu mmap support Christoph Hellwig
2015-01-16 4:06 ` Brian Norris [this message]
2015-01-14 9:42 ` [PATCH 04/12] block_dev: only write bdev inode on close Christoph Hellwig
2015-01-14 12:58 ` Jan Kara
2015-01-14 9:42 ` [PATCH 05/12] block_dev: get bdev inode bdi directly from the block device Christoph Hellwig
2015-01-14 13:00 ` Jan Kara
2015-01-14 9:42 ` [PATCH 06/12] nilfs2: set up s_bdi like the generic mount_bdev code Christoph Hellwig
2015-01-14 13:05 ` Jan Kara
2015-01-14 9:42 ` [PATCH 07/12] fs: export inode_to_bdi and use it in favor of mapping->backing_dev_info Christoph Hellwig
2015-01-14 13:31 ` Jan Kara
2015-01-14 9:42 ` [PATCH 08/12] fs: remove mapping->backing_dev_info Christoph Hellwig
2015-01-15 10:57 ` Jan Kara
2015-01-14 9:42 ` [PATCH 09/12] ceph: remove call to bdi_unregister Christoph Hellwig
2015-01-14 13:44 ` Jan Kara
2015-01-14 9:42 ` [PATCH 10/12] nfs: don't call bdi_unregister Christoph Hellwig
2015-01-14 13:51 ` Jan Kara
2015-01-14 9:42 ` [PATCH 11/12] fs: don't reassign dirty inodes to default_backing_dev_info Christoph Hellwig
2015-01-14 13:59 ` Jan Kara
2015-03-21 15:11 ` Mike Snitzer
2015-03-23 22:40 ` Mike Snitzer
2015-03-24 6:53 ` Christoph Hellwig
2015-01-14 9:42 ` [PATCH 12/12] fs: remove default_backing_dev_info Christoph Hellwig
2015-01-14 14:05 ` Jan Kara
2015-01-20 21:08 ` backing_dev_info cleanups & lifetime rule fixes V2 Jens Axboe
2015-02-01 6:31 ` Al Viro
2015-02-02 8:06 ` Christoph Hellwig
2015-02-02 17:08 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2015-01-08 17:45 backing_dev_info cleanups & lifetime rule fixes Christoph Hellwig
2015-01-08 17:45 ` [PATCH 03/12] fs: introduce f_op->mmap_capabilities for nommu mmap support Christoph Hellwig
2015-01-11 17:24 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150116040628.GG9759@ld-irv-0074 \
--to=computersforpeace@gmail.com \
--cc=axboe@fb.com \
--cc=ceph-devel@vger.kernel.org \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox