From: Andrew Morton <akpm@linux-foundation.org>
To: David Vrabel <david.vrabel@citrix.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCHv2 0/2] mm: infrastructure for correctly handling foreign pages on Xen
Date: Mon, 12 Jan 2015 12:58:46 -0800 [thread overview]
Message-ID: <20150112125846.4a5a6418c5c130c1b7669086@linux-foundation.org> (raw)
In-Reply-To: <1421077993-7909-1-git-send-email-david.vrabel@citrix.com>
On Mon, 12 Jan 2015 15:53:11 +0000 David Vrabel <david.vrabel@citrix.com> wrote:
> These two patches are the common parts of a larger Xen series[1]
> fixing several long-standing bugs the handling of foreign[2] pages in
> Xen guests.
>
> The first patch is required to fix get_user_pages[_fast]() with
> userspace space mappings of such foreign pages. Basically, pte_page()
> doesn't work so an alternate mechanism is needed to get the page from
> a VMA and address. By requiring mappings needing this method are
> 'special' this should not have an impact on the common use cases.
>
> The second patch isn't essential but helps with readability of the
> resulting user of the page flag.
>
> For further background reading see:
>
> http://xenbits.xen.org/people/dvrabel/grant-improvements-C.pdf
>
Looks OK to me. I can merge them if you like, but it's probably more
convenient for you to include them in the Xen tree.
It would be nice if PG_foreign (and PG_everythingelse) was properly
documented at the definition site.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2015-01-12 20:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 15:53 David Vrabel
2015-01-12 15:53 ` [PATCH 1/2] mm: provide a find_page vma operation David Vrabel
2015-01-12 22:35 ` Johannes Weiner
2015-01-12 15:53 ` [PATCH 2/2] mm: add 'foreign' alias for the 'pinned' page flag David Vrabel
2015-01-12 20:58 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150112125846.4a5a6418c5c130c1b7669086@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david.vrabel@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox