From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f171.google.com (mail-ig0-f171.google.com [209.85.213.171]) by kanga.kvack.org (Postfix) with ESMTP id 0FB266B006E for ; Tue, 6 Jan 2015 19:43:44 -0500 (EST) Received: by mail-ig0-f171.google.com with SMTP id z20so5063053igj.16 for ; Tue, 06 Jan 2015 16:43:43 -0800 (PST) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id v14si386101icn.79.2015.01.06.16.43.42 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Jan 2015 16:43:42 -0800 (PST) Date: Tue, 6 Jan 2015 16:43:40 -0800 From: Andrew Morton Subject: Re: [RFC] mm:change meminfo cached calculation Message-Id: <20150106164340.55e83f742d6f57c19e6500ff@linux-foundation.org> In-Reply-To: <35FD53F367049845BC99AC72306C23D103EDAF89E160@CNBJMBX05.corpusers.net> References: <35FD53F367049845BC99AC72306C23D103E688B313EE@CNBJMBX05.corpusers.net> <35FD53F367049845BC99AC72306C23D103E688B313F2@CNBJMBX05.corpusers.net> <20141205143134.37139da2208c654a0d3cd942@linux-foundation.org> <35FD53F367049845BC99AC72306C23D103E688B313F4@CNBJMBX05.corpusers.net> <20141208114601.GA28846@node.dhcp.inet.fi> <35FD53F367049845BC99AC72306C23D103E688B313FB@CNBJMBX05.corpusers.net> <35FD53F367049845BC99AC72306C23D103E688B31408@CNBJMBX05.corpusers.net> <35FD53F367049845BC99AC72306C23D103EDAF89E14C@CNBJMBX05.corpusers.net> <35FD53F367049845BC99AC72306C23D103EDAF89E160@CNBJMBX05.corpusers.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: "Wang, Yalin" Cc: "'minchan@kernel.org'" , 'Konstantin Khlebnikov' , "'Kirill A. Shutemov'" , "'linux-kernel@vger.kernel.org'" , "'linux-mm@kvack.org'" , "'linux-arm-kernel@lists.infradead.org'" , "'n-horiguchi@ah.jp.nec.com'" , "'pintu.k@samsung.com'" , Hugh Dickins linux-mm@kvack.org On Fri, 26 Dec 2014 19:56:49 +0800 "Wang, Yalin" wrote: > This patch subtract sharedram from cached, > sharedram can only be swap into swap partitions, > they should be treated as swap pages, not as cached pages. > > ... > > --- a/fs/proc/meminfo.c > +++ b/fs/proc/meminfo.c > @@ -45,7 +45,7 @@ static int meminfo_proc_show(struct seq_file *m, void *v) > committed = percpu_counter_read_positive(&vm_committed_as); > > cached = global_page_state(NR_FILE_PAGES) - > - total_swapcache_pages() - i.bufferram; > + total_swapcache_pages() - i.bufferram - i.sharedram; > if (cached < 0) > cached = 0; Documentation/filesystems/proc.txt says : Cached: in-memory cache for files read from the disk (the : pagecache). Doesn't include SwapCached So yes, I guess it should not include shmem. And why not do this as well? --- a/Documentation/filesystems/proc.txt~mm-change-meminfo-cached-calculation-fix +++ a/Documentation/filesystems/proc.txt @@ -811,7 +811,7 @@ MemAvailable: An estimate of how much me Buffers: Relatively temporary storage for raw disk blocks shouldn't get tremendously large (20MB or so) Cached: in-memory cache for files read from the disk (the - pagecache). Doesn't include SwapCached + pagecache). Doesn't include SwapCached or Shmem. SwapCached: Memory that once was swapped out, is swapped back in but still also is in the swapfile (if memory is needed it doesn't need to be swapped out AGAIN because it is already _ -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org